backend: change backend dir #303
Conversation
JonasVautherin
commented
Mar 5, 2018
JonasVautherin
commented
- backend is now in /backend instead of /grpc/server
- update readme
- change BUILD_DRONECORESERVER to BUILD_BACKEND in Makefile
| The backend is built as an executable: | ||
|
|
||
| ``` | ||
| ./build/default/backend/src/backend_bin |
There was a problem hiding this comment.
Are you sure you're placing backend executable in src ?
There was a problem hiding this comment.
Yes, that's where dronecore_server originally was. But now that you say it, maybe this is the occasion to build backend_bin, libbackend.* and backend_unit_tests in ./build/default/backend/bin? What do you think?
There was a problem hiding this comment.
I am not sure the reason behind having it in src. As you know, for DroneCore unit tests, we've in build/default/unit_tests_runner. I think ./build/default/backend/bin is also fine.
There was a problem hiding this comment.
Right. I can put them in build/default, of course.
There was a problem hiding this comment.
Actually, I am not sure what a good practice would be for that (and also maybe install should be set for the backend). I don't have much time for this right now, I just wanted to move grpc/server to backend now that not so many people are working on it.
Maybe changing the build output/install targets can be done later?
There was a problem hiding this comment.
Yeah its perfectly fine.
| @@ -45,7 +45,7 @@ target_include_directories(backend | |||
| PRIVATE | |||
| ${CMAKE_SOURCE_DIR}/core | |||
| ${CMAKE_SOURCE_DIR}/plugins | |||
| ${CMAKE_BINARY_DIR}/grpc/server/src | |||
| ${CMAKE_BINARY_DIR}/backend/src | |||
There was a problem hiding this comment.
I just noticed. Are you sure you're placing backend executable in src ?
JonasVautherin
force-pushed
the
rename-backend-dir
branch
2 times, most recently
from
584d87f
to
1df884f
Compare
* backend is now in /backend instead of /grpc/server * update readme * change BUILD_DRONECORESERVER to BUILD_BACKEND in Makefile
JonasVautherin
force-pushed
the
rename-backend-dir
branch
from
1df884f
to
16d5f79
Compare
