backend: update mission proto file #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasVautherin
force-pushed
the
268-update-mission-proto
branch
from
3c73ef5
to
e88f522
Compare
julianoes
approved these changes
Apr 3, 2018
| #include <memory> | ||
| #include <vector> | ||
|
|
||
| #include "mission/mission.h" // TODO: remove this dependency by moving the datastructs out of Mission |
There was a problem hiding this comment.
What's wrong with structs in Mission?
There was a problem hiding this comment.
Actually there are no structs in Mission class. @JonasVautherin Did you mean them in MissionItem class ?
There was a problem hiding this comment.
I was thinking about Mission::Result. But it is not necessary in this PR, so the comment is superfluous.
| namespace dronecore { | ||
| namespace backend { | ||
|
|
||
| template <typename Mission> |
There was a problem hiding this comment.
I think I forgot. Why do we need template argument ?
There was a problem hiding this comment.
For testing. I want to pass a MockMission in the tests.
| #include <memory> | ||
| #include <vector> | ||
|
|
||
| #include "mission/mission.h" // TODO: remove this dependency by moving the datastructs out of Mission |
There was a problem hiding this comment.
Actually there are no structs in Mission class. @JonasVautherin Did you mean them in MissionItem class ?
JonasVautherin
force-pushed
the
268-update-mission-proto
branch
from
e88f522
to
e27b3cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the mission proto file. For now it is only setting up the new mission proto file, without implementing any actual feature. That's mainly for moving on to #269.
Fixes #268.