-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build_system: remove unused-parameter flag for AppleClang #354
Conversation
Sources generated by protobuf do not compile otherwise.
@@ -5,6 +5,8 @@ set(CMAKE_CXX_STANDARD 11) | |||
|
|||
list(APPEND CMAKE_FIND_ROOT_PATH ${CMAKE_BINARY_DIR}/third_party) | |||
|
|||
cmake_policy(SET CMP0025 NEW) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment why this was needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do it if you insist, but I tend to disagree on that :-). "CMP0025" is so unique that you cannot miss the CMake documentation when Googling it, and its first line says:
Compiler id for Apple Clang is now AppleClang.
I generally don't like adding comments, but I agree it is necessary sometimes when we have to do weird tricks. This is not a trick at all. To me it would be the same as as putting a comment above std::shared_ptr<...>
to explain what a shared pointer is. It is general knowledge, and I believe my source code is not the place for general documentation :D. Comments tend to get outdated and clutter the code.
Again, if you insist, I can add a comment there :D.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, agreed.
@@ -5,6 +5,8 @@ set(CMAKE_CXX_STANDARD 11) | |||
|
|||
list(APPEND CMAKE_FIND_ROOT_PATH ${CMAKE_BINARY_DIR}/third_party) | |||
|
|||
cmake_policy(SET CMP0025 NEW) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, agreed.
build_system: remove unused-parameter flag for AppleClang
Sources generated by protobuf do not compile otherwise. I tried to set the flag only for the generated files with
set_source_files_properties
, but didn't manage to make it work this way.