backend: add health to telemetry #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasVautherin
force-pushed
the
333-telemetry-health
branch
from
c7a2a4c
to
5f908cc
Compare
| const dronecore::rpc::telemetry::SubscribeHealthRequest * /* request */, | ||
| grpc::ServerWriter<rpc::telemetry::HealthResponse> *writer) override | ||
| { | ||
| _telemetry.health_async([&writer](dronecore::Telemetry::Health health) { |
| @@ -106,24 +121,46 @@ std::future<void> TelemetryServiceImplTest::subscribePositionAsync(std::vector<P | |||
| }); | |||
| } | |||
|
|
|||
| TEST_F(TelemetryServiceImplTest, doesNotSendPositionIfCallbackNotCalled) | |||
There was a problem hiding this comment.
Nice name: doesNotSendPositionIfCallbackNotCalled :-)
| EXPECT_CALL(*_telemetry, health_async(_)) | ||
| .Times(1); | ||
|
|
||
| std::vector<Health> healths; |
There was a problem hiding this comment.
Why a vector ? Health is meant for a system/vehicle isn't it ?
There was a problem hiding this comment.
I'm not sure I understand the question. I collect the Health events sent by the drone in this vector, for the test...
How would you do it?
julianoes
approved these changes
Apr 12, 2018
| { | ||
| return str << "[gyrometer_calibration_ok: " << health.gyrometer_calibration_ok << | ||
| ", accelerometer_calibration_ok: " << health.accelerometer_calibration_ok << | ||
| ", magnetometer_calibration_ok: " << health.magnetometer_calibration_ok << |
There was a problem hiding this comment.
I usually start these lines with << and indent it in the same way. Just for next time.
There was a problem hiding this comment.
I did not think about it and let astyle do it. But I prefer you're way. I'll change it.
There was a problem hiding this comment.
Well, I'm actually moving that in the next PR, so I'll change it at this time :-).
JonasVautherin
force-pushed
the
333-telemetry-health
branch
from
5f908cc
to
25e0f53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #333.