build_system: build tinyxml2 statically #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
reviewed
May 4, 2018
JonasVautherin
force-pushed
the
build-tinyxml-statically
branch
from
0801ef9
to
8f30130
Compare
SITL autostart is not working on Windows, so we might as well warn. Also, it's good practice to use they keyword override.
julianoes
force-pushed
the
build-tinyxml-statically
branch
from
6777ede
to
d2b0079
Compare
|
Haha, now the tests are all inverted. Just need to keep the best of both solutions 😅. |
julianoes
approved these changes
May 9, 2018
rt-2pm2
pushed a commit
to rt-2pm2/DronecodeSDK
that referenced
this pull request
Nov 27, 2018
build_system: build tinyxml2 statically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build tinyxml2 statically (to fix the build for iOS).
It may look a bit hacky, but I did not want to pollute the whole scope with options set only for tinyxml2. One alternative would be to fork tinyxml2 and modify its
CMakeLists.txt, and another one would be to not build tinyxml2 as a submodule (I would like to do that at some point, some kind of "super-build" scheme).At least it is contained into
cmake/tinyxml2.cmakefor now.@julianoes let me know if you think we should link it dynamically for some platforms.