Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch default scroll wheel action when hovering, add keybindings. #155

Closed
GrimPixel opened this issue Dec 2, 2022 · 9 comments
Closed
Assignees
Labels
feature New feature or request
Milestone

Comments

@GrimPixel
Copy link

GrimPixel commented Dec 2, 2022

When I play the chess, I have to click the left mouse button, press the Ctrl key, then scroll the mouse wheel. This is the biggest inconsideration by far. I think I could simply press Ctrl or Shift to lift and drop pieces. Many other operations also require two keys pressed together.

@elmodor
Copy link
Contributor

elmodor commented Dec 3, 2022

I would be able implement keybindings to raise/lower pieces if that's okay with @drwhut .

Which keys should be used to raise/lower the pieces? This is a keybinding that should only work when hovering a piece. Since Ctrl and Shift are already bound to other actions we would 2 other keys for this.

@GrimPixel
Copy link
Author

I see. Q, E, Z, X, C are unassigned (on QWERTY layout).

@drwhut
Copy link
Owner

drwhut commented Dec 6, 2022

I had an idea after #140 was implemented - with your specific example, what if the current Ctrl+Scroll Wheel functionality was the default (as in, just Scroll Wheel would lift the piece perpendicular to the table, rather than towards/away from the camera)? Since pieces no longer change horizontal position when they are initially hovered, maybe this change could be made consistent to how one lifts a piece?

@elmodor
Copy link
Contributor

elmodor commented Dec 6, 2022

Actually I had the same idea.
So we swap the ctrl+scrollwheel and scrollwheel functionality for hovered pieces?
Do we still want to add keybindings to raise the piece? Maybe it's more convenient to press some keys instead to use the scrollwheel?

@drwhut
Copy link
Owner

drwhut commented Dec 6, 2022

That would make sense - this is somewhat subjective though, so I'll ask some of the alpha testers what they think. Feel free to comment (anyone!) as well what you think would be the most intuitive way of going about this.

@GrimPixel
Copy link
Author

An object in 3D space has 6 degrees of freedom. The mouse movements control x and y, the mouse wheel controls the z.

@drwhut
Copy link
Owner

drwhut commented Dec 13, 2022

For the next beta test, I'm going to try switching the default scroll wheel action to lifting pieces (perpendicular to the table), and having Ctrl+Scroll Wheel be zooming the piece in and out of the camera. I'll also think about key bindings to do this, as well.

@drwhut drwhut changed the title Improve key bindings Switch default scroll wheel action when hovering, add keybindings. Dec 13, 2022
@drwhut drwhut added the feature New feature or request label Dec 13, 2022
@drwhut drwhut self-assigned this Dec 13, 2022
@drwhut drwhut added this to the v0.1.0 milestone Dec 13, 2022
@elmodor
Copy link
Contributor

elmodor commented Dec 13, 2022

Sounds good! Would be cool if the scrollwheel would be a changeable keybind - if that is possible in godot.

@drwhut
Copy link
Owner

drwhut commented Dec 13, 2022

AFAIK the only way to get scroll wheel input is via _input() or _unprocessed_input() - but I'll have another look at the docs to see if there is a way, since that would simplify things.

@drwhut drwhut closed this as completed in c35e8b8 Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants