Allow empty groups #208
Merged
Allow empty groups #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 029a160 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
drwpow
reviewed
Mar 5, 2024
| "@cobalt-ui/core": patch | ||
| --- | ||
|
|
||
| Allows DTCG files to contain empty groups. Previously they would cause a parsing error, now only a warning will be logged. |
There was a problem hiding this comment.
👍 Perfect! Agreed this should just be a patch.
drwpow
reviewed
Mar 5, 2024
| @@ -42,6 +42,15 @@ describe('5. Group', () => { | |||
| const tokens = getTokens(json); | |||
| expect(tokens.find((t) => t.id === 'color.blue')!.$type).toBe('color'); | |||
| }); | |||
|
|
|||
| test('allow empty', () => { | |||
drwpow
approved these changes
Mar 5, 2024
|
This is great, thank you! After this merges, changeset will ship it to npm. 🎉 |
Merged
|
Hurray! Thanks for the quick review & release. Much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Makes the parser log a warning instead of an error when it encounters an empty group. Closes #206.
How to Review
Refer to the discussion in #206 for the rationale behind this change in behaviour.
I added a regression test that fails without this fix and passes with it. However, I'm not sure if the
expect(tokens.length).toBe(0)line is really needed, asgetTokens()already has anexpect()assertion to check that there were no parsing errors. It felt a bit weird having a test without anexpect()in it though, so I added that. Happy to remove it, if you think that's cleaner / clearer.Since this is a bug fix, I've classed it as a patch change in the changeset.