Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support monorepo structure (npm 7 / lerna etc..) #289

Closed
jony89 opened this issue Feb 10, 2021 · 1 comment
Closed

support monorepo structure (npm 7 / lerna etc..) #289

jony89 opened this issue Feb 10, 2021 · 1 comment

Comments

@jony89
Copy link

jony89 commented Feb 10, 2021

patch-package currently does not support npm7 workspaces or any monorepo structure.

This is a monorepo structure for example:

package.json
apps
  app1
   - package.json
  app2
   - package.json

npm 7 installs packages from app1 that exist only in app1, for example, within the root node_modules and not in app1/node_modules, thus while running npx patch-package my-package I get the error "my-package does not exist / not found".

So in order to support that we need to check if the package does exist in app1/package.json to keep looking for the package but in the node_modules folder that is higher in the hierarchy and has package.json as well.

@jony89 jony89 changed the title support monorepo structure (npm 7 support monorepo structure (npm 7) Feb 10, 2021
@jony89 jony89 changed the title support monorepo structure (npm 7) support monorepo structure (npm 7 / lerna etc..) Feb 10, 2021
@jony89
Copy link
Author

jony89 commented Feb 10, 2021

duplicates #277

@jony89 jony89 closed this as completed Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant