Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xWindowsProcess: Integration tests fails randomly #420

Closed
johlju opened this issue May 22, 2018 · 2 comments
Closed

xWindowsProcess: Integration tests fails randomly #420

johlju opened this issue May 22, 2018 · 2 comments
Labels
bug The issue is a bug.

Comments

@johlju
Copy link
Member

johlju commented May 22, 2018

The integration tests for xWindowsProcess fail to create log file, often, but sometimes the tests passes without a problem.

Context Should start a new testProcess instance as running
      [+] Should not have a logfile already present 83ms
The 'Microsoft.PowerShell.Management' module was not imported because the 'Microsoft.PowerShell.Management' snap-in was already imported.
      [+] Should compile without throwing 490ms
      [+] Should be able to call Get-DscConfiguration without throwing 132ms
      [+] Should return the correct configuration 145ms
      [-] Should create a logfile 76ms
        Expected $true, but got $false.
        105:                 $pathResult | Should Be $true
        at Invoke-LegacyAssertion, C:\Program Files\WindowsPowerShell\Modules\Pester\4.3.1\Functions\Assertions\Should.ps1: line 188
        at <ScriptBlock>, C:\projects\xpsdesiredstateconfiguration\Tests\Integration\MSFT_xWindowsProcess.Integration.Tests.ps1: line 105
@johlju johlju added bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community. labels May 22, 2018
@johlju
Copy link
Member Author

johlju commented May 22, 2018

The same problem exist in PowerShell/PSDscResources#76.

johlju added a commit to johlju/xPSDesiredStateConfiguration that referenced this issue May 22, 2018
- Integration tests for this resource should no longer fail randomly. A timing
  issue made the tests fail in certain scenarios (issue dsccommunity#420).
johlju added a commit that referenced this issue May 22, 2018
- Changes to xWindowsProcess
  - Integration tests for this resource should no longer fail randomly. A timing
    issue made the tests fail in certain scenarios (issue #420).
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label May 22, 2018
@johlju
Copy link
Member Author

johlju commented May 22, 2018

A potential fix for this was merged in PR #421.

@johlju johlju closed this as completed May 22, 2018
johlju added a commit to johlju/xPSDesiredStateConfiguration that referenced this issue Jun 20, 2018
- Increased the wait time in the integration tests since the tests
  still failed randomly (issue dsccommunity#420).
johlju added a commit to johlju/xPSDesiredStateConfiguration that referenced this issue Jun 20, 2018
- Increased the wait time in the integration tests since the tests
  still failed randomly (issue dsccommunity#420).
johlju added a commit to johlju/xPSDesiredStateConfiguration that referenced this issue Jun 21, 2018
- Increased the wait time in the integration tests since the tests
  still failed randomly (issue dsccommunity#420).
johlju added a commit that referenced this issue Jul 3, 2018
- Changes to xWindowsProcess
  - Increased the wait time in the integration tests since the tests
    still failed randomly (issue #420).
- Renamed and updated examples to be able to publish them to PowerShell Gallery.
  - Sample_xScript.ps1 → xScript_WatchFileContentConfig.ps1
  - Sample_xService_UpdateStartupTypeIgnoreState.ps1 → xService_UpdateStartupTypeIgnoreStateConfig.ps1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug.
Projects
None yet
Development

No branches or pull requests

1 participant