Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xRemoteFile: Fix inconsistencies in messages for en-us #716

Closed
BITespresso opened this issue May 20, 2021 · 3 comments · Fixed by #717
Closed

xRemoteFile: Fix inconsistencies in messages for en-us #716

BITespresso opened this issue May 20, 2021 · 3 comments · Fixed by #717
Labels
enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone.

Comments

@BITespresso
Copy link
Contributor

Details of the scenario you tried and the problem that is occurring

The message string defined in DSC_xRemoteFile.strings.psd1 have some inconsistencies in quoting and case:

Examples:

Specified URI is not valid: "{0}". Only http, https or file paths are accepted.
(uses double quotes and uppercase URI)

vs

No cache found for DestinationPath '{0}' and Uri '{1}' CacheKey '{2}'.
(uses single quotes and Uri instead of URI)

Suggested solution to the issue

Fix message strings
@BITespresso
Copy link
Contributor Author

I'd like to resolve this issue.

@BITespresso BITespresso mentioned this issue May 20, 2021
Merged
9 tasks
@PlagueHO PlagueHO added enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone. labels May 21, 2021
@PlagueHO
Copy link
Member

Hi @BITespresso - your help is greatly appreciated. Please feel free to submit a pull request for this and I'll get onto review this weekend.

@BITespresso
Copy link
Contributor Author

The pull request should already be here and is complete from my side. Looking forward to your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xRemoteFile: Fix inconsistencies in messages for en-us BITespresso/xPSDesiredStateConfiguration
2 participants
@BITespresso @PlagueHO