-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples to PowerShell Gallery #429
Conversation
- Increased the wait time in the integration tests since the tests still failed randomly (issue dsccommunity#420).
This will not work until
|
Codecov Report
@@ Coverage Diff @@
## dev #429 +/- ##
===================================
Coverage 73% 73%
===================================
Files 27 27
Lines 3995 3995
Branches 4 4
===================================
Hits 2921 2921
Misses 1070 1070
Partials 4 4 |
Reviewed 6 of 6 files at r1. appveyor.yml, line 1 at r1 (raw file):
The DscResource.Template should be updated with this. appveyor.yml, line 8 at r1 (raw file):
Should have the correct API key README.md, line 668 at r1 (raw file):
We should escape underscore in markdown. Examples/xService_UpdateStartupTypeIgnoreStateConfig.ps1, line 1 at r1 (raw file): Remove blank row. Examples/xScript_WatchFileContentConfig.ps1, line 1 at r1 (raw file): Remove blank row. Examples/xScript_WatchFileContentConfig.ps1, line 31 at r1 (raw file):
No longer true. Examples/xScript_WatchFileContentConfig.ps1, line 35 at r1 (raw file):
No longer true. Comments from Reviewable |
Review status: all files reviewed, 12 unresolved discussions Examples/xService_UpdateStartupTypeIgnoreStateConfig.ps1, line 22 at r1 (raw file):
We should have .SYNOPSIS to so Get-Help looks pretty (that defaults to .SYNOPSIS)? Examples/xService_UpdateStartupTypeIgnoreStateConfig.ps1, line 23 at r1 (raw file):
'Configuration that updates startup...' Examples/xService_UpdateStartupTypeIgnoreStateConfig.ps1, line 26 at r1 (raw file):
Add an .EXAMPLE too? Examples/xScript_WatchFileContentConfig.ps1, line 23 at r1 (raw file):
'Configuration that creates a file...' Examples/xScript_WatchFileContentConfig.ps1, line 33 at r1 (raw file):
Add an .EXAMPLE too? Comments from Reviewable |
Review status: all files reviewed, 13 unresolved discussions README.md, line 441 at r1 (raw file):
Examples need to be updated here Comments from Reviewable |
Review status: 5 of 7 files reviewed, 11 unresolved discussions (waiting on @johlju) appveyor.yml, line 1 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. Proposed in PR PowerShell/DscResources#411. Comments from Reviewable |
Reviewed 5 of 5 files at r2. README.md, line 441 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. README.md, line 668 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done. Examples/xService_UpdateStartupTypeIgnoreStateConfig.ps1, line 1 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done Examples/xService_UpdateStartupTypeIgnoreStateConfig.ps1, line 22 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done Examples/xService_UpdateStartupTypeIgnoreStateConfig.ps1, line 23 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done Examples/xService_UpdateStartupTypeIgnoreStateConfig.ps1, line 26 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done Examples/xScript_WatchFileContentConfig.ps1, line 1 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done Examples/xScript_WatchFileContentConfig.ps1, line 23 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done Examples/xScript_WatchFileContentConfig.ps1, line 31 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done Examples/xScript_WatchFileContentConfig.ps1, line 33 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done Examples/xScript_WatchFileContentConfig.ps1, line 35 at r1 (raw file): Previously, johlju (Johan Ljunggren) wrote…
Done Comments from Reviewable |
Closing and reopening to run this against newly update DscResource.Tests |
Review status: complete! all files reviewed, all discussions resolved Comments from Reviewable |
still failed randomly (issue #420).
This change is