Add urlPrefix option #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding files to Sentry's release artifacts.
|
@dguayrobotiq Congrats on getting this figured out! Is there any reason to have both publicUrl and urlPrefix? It seems like they are used for the same purpose. |
|
Gosh I feel so dumb. I think you're right and my PR is useless. By reading the README, I really thought I'll test that and decline that PR... |
|
@dguayrobotiq definitely not dumb -- other people could and will make the same mistake. Perhaps you could change the PR into a documentation PR that updates the README to clearly address information that would have helped "you" a week ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47
Add
urlPrefixoption to replacepublicUrlin the file name when uploading files to Sentry's release artifacts.If the assets are stored on Cloudfront, files would normally be named something like
https://xxxx.cloudfront.net/assets/...in Sentry's release artifacts. If you seturlPrefixto~, files will instead be named~/assets/....