Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatibility with gzip plugin #8

Closed
bastianlb opened this issue Jan 21, 2016 · 9 comments
Closed

incompatibility with gzip plugin #8

bastianlb opened this issue Jan 21, 2016 · 9 comments

Comments

@bastianlb
Copy link

sentry doesn't support gzipped source maps, so when used in combination with the gzip plugin, the source maps/js files aren't useful. Is there a way to make this plugin send the source files before they get gzipped?

@bastianlb
Copy link
Author

i've tried adding before: ember-cli-deploy-gzip in package.json as described in the documentation, although this doesn't seem to work.. Sentry still reports a bad encoding. However, disabling the gzip plugin for .js and .map files fixes this..

@dschmidt
Copy link
Owner

This is odd, I have zero issues with the gzip plugin used alongside ember-cli-deploy-sentry.

Will need to investigate...

@dschmidt
Copy link
Owner

What exactly is the issue you're seeing? Any errors I can try to reproduce?

@bastianlb
Copy link
Author

Sure, when getsentry.com gets an event with source files it can't parse they report a utf-8 error:

There were 2 errors encountered while processing this event
Source file was not 'utf8' encoding: https://asdfasdf123.cloudfront.net/assets/vendor-30820b336a9f.js Expand
Source file was not 'utf8' encoding: https://asdfasdf123.cloudfront.net/assets/client-30820b336a9f.js Expand

@bastianlb
Copy link
Author

Up until recently, sentry swallowed these errors silently.. see here: getsentry/sentry@3124ce5

@dschmidt
Copy link
Owner

Interesting, wondering why it works for me then

@dschmidt
Copy link
Owner

Although this should work of course .. here's a workaround that might work for you:

use the keep option of ember-cli-deploy-gzip and configure your webserver to serve .gz files if present (c.f. https://www.npmjs.com/package/ember-cli-deploy-gzip#keep)

for nginx the config option is gzip_static: http://nginx.org/en/docs/http/ngx_http_gzip_static_module.html

@dschmidt
Copy link
Owner

Does this issue remain? Or is it maybe fixed with the juggling around of hooks?

@dschmidt
Copy link
Owner

Closing, due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants