Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: spawn EINVAL error #291

Open
RainArroDev opened this issue Nov 8, 2024 · 0 comments
Open

Windows: spawn EINVAL error #291

RainArroDev opened this issue Nov 8, 2024 · 0 comments

Comments

@RainArroDev
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch dax-sh@0.39.2 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/dax-sh/esm/mod.js b/node_modules/dax-sh/esm/mod.js
index 71cb378..b562995 100644
--- a/node_modules/dax-sh/esm/mod.js
+++ b/node_modules/dax-sh/esm/mod.js
@@ -6248,6 +6248,8 @@ function toNodeStdio(stdio) {
 }
 var spawnCommand = (path, options) => {
   let receivedSignal;
+  const isWindows = process.platform === 'win32';
+
   const child = cp.spawn(path, options.args, {
     cwd: options.cwd,
     // todo: clearEnv on node?
@@ -6256,7 +6258,8 @@ var spawnCommand = (path, options) => {
       toNodeStdio(options.stdin),
       toNodeStdio(options.stdout),
       toNodeStdio(options.stderr)
-    ]
+    ],
+    shell: isWindows,
   });
   const exitResolvers = Promise.withResolvers();
   child.on("exit", (code2) => {

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant