feat: add mkdir command #34
Conversation
|
It seems like you're not using the default dprint config ?, but https://github.com/dsherret/dax/blob/main/dprint.json doesn't have any configuration |
|
dprint leaves a lot of code as-is, so I think maybe something else is formatting the files while you're working on them? The default width for dprint is 120 characters for example, so it seems like something else is formatting the files. Would you be able to revert all formatting changes with git? |
|
I'll align dprint with deno fmt after we merge this PR. I'm using it because there's also rust in this project. Edit: I went ahead and merged it because it was quiet minimal #37 |
mod.test.ts
Outdated
| @@ -736,3 +736,33 @@ Deno.test("test remove", async () => { | |||
| await $`rm -r ${nonEmptyDir}`; | |||
| assertEquals($.fs.existsSync(nonEmptyDir), false); | |||
| }); | |||
|
|
|||
| Deno.test("test mkdir", async () => { | |||
| const dir = Deno.makeTempDirSync(); | |||
There was a problem hiding this comment.
In #40 I just added a withTempDir helper. Let's use that here to ensure that these temporary directories get cleaned up after the test is run.
src/commands/mkdir.ts
Outdated
| } | ||
| } | ||
|
|
||
| interface mkdirFlags { |
There was a problem hiding this comment.
Let's change this to start with a capital: MkdirFlags
mod.test.ts
Outdated
| .then( | ||
| (r) => r.stderr, | ||
| ); | ||
| const expecteError = Deno.build.os === "windows" |
src/utils.ts
Outdated
| @@ -0,0 +1,15 @@ | |||
| export async function stat( | |||
There was a problem hiding this comment.
Maybe call this lstat since it's using Deno.lstat and not Deno.stat?
src/utils.ts
Outdated
| ) { | ||
| try { | ||
| const info = await Deno.lstat(path); | ||
| return test(info); |
There was a problem hiding this comment.
Maybe we should just return Deno.FileInfo | undefined from this function? Then we could do a stat call once in the code above. Right now we're doing possibly two stat calls per path instead of max 1.
There was a problem hiding this comment.
I added the other suggestions, but I don't get this one, how can lstat happen twice ?
There was a problem hiding this comment.
Actually I see your point, can you merge this as is (if there are no other issues), and I'll do the changes in the other pr
I run
drpint fmtstill same issue, is there something I need to do ?