Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build for TS 4.0 #79

Closed
dsherret opened this issue Sep 26, 2020 · 4 comments
Closed

Fix build for TS 4.0 #79

dsherret opened this issue Sep 26, 2020 · 4 comments
Labels
bug

Comments

@dsherret
Copy link
Owner

Looks like TypeScript renaming a property on the TupleType node broke a lot of stuff.

Waiting on facebook/create-react-app#9515 to be fixed.
@dsherret dsherret added the bug label Sep 26, 2020
@dsherret
Copy link
Owner Author

dsherret commented Oct 24, 2020 •
edited
Loading

I should just drop create react app eventually as I don't really need it. Now waiting on these two new bugs:

@dsherret dsherret mentioned this issue Oct 24, 2020
Closed
@dsherret
Copy link
Owner Author

Ended up just implementing #82. create-react-app does not seem to value TypeScript support.

@ChristianIvicevic
Copy link

ChristianIvicevic commented Nov 14, 2020 •
edited
Loading

Offtopic banter: Just saw your issue referenced over in CRA, the mentioned fix in one of the issues, especially the comment at the end of the post is pure gold: facebook/create-react-app#9868 (comment)

Unfortunately create-react-app will most likely not consider Typescript a first-class citizen for a long time...

@dsherret
Copy link
Owner Author

@ChristianIvicevic that's kind of funny, but also disappointing 😐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsherret @ChristianIvicevic