Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement registerKeyPair() flow in API #15

Open
kern opened this issue Jun 8, 2018 · 3 comments
Open

Implement registerKeyPair() flow in API #15

kern opened this issue Jun 8, 2018 · 3 comments
Assignees

Comments

@kern
Copy link
Member

kern commented Jun 8, 2018

type Query {
  keyPairChallenge(publicKey: String!): String!
  keyPair(publicKey: String!, network: ETHEREUM_NETWORK): KeyPair
}

type Mutation {
  registerKeyPair(
    publicKey: String!
    name: String
    deviceType: DEVICE_TYPE
    challenge: String!
    signature: String!
  ): KeyPair!
}


type KeyPair {
  publicKey: String!
  name: String
  deviceType: DEVICE_TYPE
}

enum DEVICE_TYPE {
  DESKTOP
  IOS
  ANDROID
  OTHER
}
@kern kern self-assigned this Jun 8, 2018
@kern kern added the enhancement New feature or request label Jun 8, 2018
@kern
Copy link
Member Author

kern commented Jun 8, 2018

concern: everyone can read everyone else's key pair information, which is obviously not ideal. perhaps there's an access token system that uses the key pair challenge, which can be used to detect if a key pair should be accessible or not? or perhaps if the key pair's metadata is accessible?

@kern
Copy link
Member Author

kern commented Jun 18, 2018

possible solution: whenever registering a keypair, associate it with an identity contract as well. that way, each keypair is only associated with the intended identity, as opposed to any identity (which could lead to information leakage).

@kern kern removed the enhancement New feature or request label Jun 19, 2018
@kern
Copy link
Member Author

kern commented Jun 19, 2018

putting this on the backlog until we have better support for multi-device identities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant