From 42aad8af444a6aec2d30c0fcf536e3ffd8c1e6ee Mon Sep 17 00:00:00 2001
From: Howard Soh <hsoh@seneca.rap.ucar.edu>
Date: Thu, 10 Feb 2022 21:17:01 -0700
Subject: [PATCH] #2044 ci-run-unit Give warning if bad connfig key is used

---
 met/src/tools/other/pb2nc/pb2nc_conf_info.cc | 40 ++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/met/src/tools/other/pb2nc/pb2nc_conf_info.cc b/met/src/tools/other/pb2nc/pb2nc_conf_info.cc
index d940939072..3c3a53c74a 100644
--- a/met/src/tools/other/pb2nc/pb2nc_conf_info.cc
+++ b/met/src/tools/other/pb2nc/pb2nc_conf_info.cc
@@ -25,6 +25,18 @@ using namespace std;
 #include "grib_strings.h"
 #include "vx_log.h"
 
+
+////////////////////////////////////////////////////////////////////////
+
+map<ConcatString,ConcatString> parse_conf_obs_bufr_map(Dictionary *dict) {
+
+   const char *key_name = (0 != dict->lookup_array(conf_key_obs_prepbufr_map, false, false))
+                          ? conf_key_obs_prepbufr_map : conf_key_old_prepbufr_map;
+   map<ConcatString,ConcatString> m = parse_conf_key_value_map(dict, (const char *)key_name);
+   parse_add_conf_key_value_map(dict, conf_key_obs_bufr_map, &m);
+   return m;
+}
+
 ////////////////////////////////////////////////////////////////////////
 //
 //  Code for class PB2NCConfInfo
@@ -85,14 +97,42 @@ void PB2NCConfInfo::clear() {
 void PB2NCConfInfo::read_config(const char *default_file_name,
                                 const char *user_file_name) {
 
+   int warning_code = 0;
+   bool use_bad_one = true;
+   string bad_file_names;
+
    // Read the config file constants
    conf.read(replace_path(config_const_filename).c_str());
 
    // Read the default config file
    conf.read(default_file_name);
+   if (0 != conf.lookup_array(conf_key_old_prepbufr_map, false, false)) {
+      warning_code = 1;
+      bad_file_names = default_file_name;
+      if (0 != conf.lookup_array(conf_key_obs_prepbufr_map, false, false)) use_bad_one = false;
+   }
 
    // Read the user-specified config file
    conf.read(user_file_name);
+   if (0 != conf.lookup_array(conf_key_old_prepbufr_map, false, false)) {
+      warning_code = 2;
+      if (0 < bad_file_names.length()) bad_file_names += " and ";
+      bad_file_names += user_file_name;
+      if (0 != conf.lookup_array(conf_key_obs_prepbufr_map, false, false)) use_bad_one = false;
+   }
+
+   if (0 < warning_code) {
+      string ignored_message = " ";
+
+      if (!use_bad_one) {
+         ignored_message = " (Ignored \"";
+         ignored_message += conf_key_old_prepbufr_map;
+         ignored_message += "\" key)";
+      }
+      mlog << Warning << "\nPlease rename the configuration key \""
+           << conf_key_old_prepbufr_map << "\" to \"" << conf_key_obs_prepbufr_map
+           << "\" at " << bad_file_names << ignored_message << "\n\n";
+   }
 
    return;
 }