Resolve PB2NC string truncation warning messages.

[JohnHalleyGotway]

Describe the Task

Pull requests for Issue #1855 introduced several hundred warning messages when running PB2NC. These are evident when running:

make test >& make_test.log

Here's the resulting make.log file.
It contains 986 new warning messages:

grep WARNING make_test.log | grep get_variable_info | wc -l
     986

And here's what one looks like:

WARNING:   get_variable_info() truncated a string var_name from "SAID     | 001007 | SATELLITE IDENTIFIER (SATELLITE REPORTS ONLY)            |
WARNING: " to "SAID    "

This task is investigate this situation and get rid of that warning. I suspect that the vertical bar '|' should be interpreted as a field separator. Could you use strtok or string split instead so that this doesn't trigger a warning message?

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the task down into sub-issues.

• Add a checkbox for each sub-issue here.

Relevant Deadlines

Please fix in the next development cycle, met-10.1.0-beta3.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

• Select engineer(s) or no engineer required: Howard
• Select scientist(s) or no scientist required: none required

Labels

• Select component(s)
• Select priority
• Select requestor(s)

Projects and Milestone

• Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
• Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

• METplus, MET, METdatadb, METviewer, METexpress, METcalcpy, METplotpy
  No impacts.

Task Checklist

See the METplus Workflow for details.

• Complete the issue definition above, including the Time Estimate and Funding Source.
• Fork this repository or create a branch of develop.
  Branch name: feature_<Issue Number>_<Description>
• Complete the development and test your changes.
• Add/update log messages for easier debugging.
• Add/update unit tests.
• Add/update documentation.
• Push local changes to GitHub.
• Submit a pull request to merge into develop.
  Pull request: feature <Issue Number> <Description>
• Define the pull request metadata, as permissions allow.
  Select: Reviewer(s) and Linked issues
  Select: Repository level development cycle Project for the next official release
  Select: Milestone as the next official version
• Iterate until the reviewer(s) accept and merge your changes.
• Delete your fork or branch.
• Close this issue.

[hsoh-u]

This was introduced by checking the result of stpcpy APIs: give warnings if the string is truncated. strnpy does truncate if the target string buffer is smaller than the source string buffer. The checking should be skipped in this case. This will be implemented at m_strXXX API with #1903

[hsoh-u]

Fixed with #1903