Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure the Tropical Cyclone unit test input files. #2000

Open
21 tasks
JohnHalleyGotway opened this issue Jan 5, 2022 · 0 comments
Open
21 tasks

Restructure the Tropical Cyclone unit test input files. #2000

JohnHalleyGotway opened this issue Jan 5, 2022 · 0 comments
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: testing Software testing issue MET: Tropical Cyclone Tools priority: medium Medium Priority requestor: METplus Team METplus Development Team type: task An actionable item of work

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Jan 5, 2022

Describe the Task

This issue arose during development for MET #1810 which adds a new call to tc_gen. The TC input data for the unit tests is a bit messy. This task is to reorganize that input data into yearly subdirectories AND update the unit tests accordingly. Note that this will require:

  • Updating the unit tests in the develop, develop-ref, main_v10.0, main_v10.0-ref, main_v10.1, and main_v10.1-ref branches.
  • Modifying the input datasets on NCAR project machines as well as the archived data versions.

The tc_data directory should contain:

  • adeck/YYYY directories for each year of model track data
  • bdeck/YYYY directories for each year of Best track data
  • edeck/YYYY directories for each year of ensemble deck track data
  • genesis/suite1/YYYYMMDDHH directories
  • genesis/shape/{atl, cpc, epac}/YYYYMMDDHHMM directories for advisories

Note that genesis/atcf/YYYY data should be MOVED over into adeck and bdeck directories.

We also need to confirm that changes to this directory structure and unit tests DO NOT change any of the existing output.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the task down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added component: testing Software testing issue type: task An actionable item of work priority: medium Medium Priority alert: NEED ACCOUNT KEY Need to assign an account key to this issue requestor: METplus Team METplus Development Team MET: Tropical Cyclone Tools labels Jan 5, 2022
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.0.0 milestone Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: testing Software testing issue MET: Tropical Cyclone Tools priority: medium Medium Priority requestor: METplus Team METplus Development Team type: task An actionable item of work
Projects
None yet
Development

No branches or pull requests

1 participant