Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Fix support for OSI-SAF sea ice concentration data on LAEA grids in CF-compliant NetCDF files #2651

Open
7 of 22 tasks
JohnHalleyGotway opened this issue Aug 16, 2023 · 1 comment
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle MET: Library Code MET: Plotting Tools priority: high High Priority requestor: NOAA/EMC NOAA Environmental Modeling Center type: bug Fix something that is not working

Comments

@JohnHalleyGotway
Copy link
Collaborator

Describe the Problem

This issue was raised in the second topic of the dtcenter/METplus#2312 discussion. Please see this comment for details.

Expected Behavior

While the sample NetCDF file follows the CF-convention, MET is not properly parsing the LAEA grid from it. This issue is to correct that support. MET should be able to parse CF-compliant LAEA grid definitions. And if the grid specifications do not actually follow the convention, MET should error out with a error message stating as much.

Environment

Describe your runtime environment:
1. Machine: Mac Laptop
2. OS: MacOS
3. Software version number(s): Tested using the main_v11.1 branch of MET

To Reproduce

Describe the steps to reproduce the behavior:
1. Download this file:
ice_conc_nh_ease-125_cont-reproc_201908071200.nc.gz
2. Run plot_data_plane at verbosity level 4:

MET-main_v11.1/bin/plot_data_plane ice_conc_nh_ease-125_cont-reproc_201908071200.nc plot.ps 'name="ice_conc"; level="(0,*,*)";' -v 4

3. Note the incorrect grid definition:

DEBUG 4: Grid information:
DEBUG 4:    Projection: Lambert Azimuthal Equal Area
DEBUG 4:    Nx: 849
DEBUG 4:    Ny: 849
DEBUG 4:    SpheroidName: Undefined
DEBUG 4:    Lat_LL: nan
DEBUG 4:    Lon_LL: nan
DEBUG 4:    Lat_Pole: 90.000
DEBUG 4:    Lon_Pole: -0.000

The Lat_LL and Lon_LL entries should NOT be nan.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Organization level Project for support of the current coordinated release
  • Select Repository level Project for development toward the next official release or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Organization level software support Project for the current coordinated release
    Select: Milestone as the next bugfix version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Development issue
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: bug Fix something that is not working requestor: NOAA/EMC NOAA Environmental Modeling Center alert: NEED ACCOUNT KEY Need to assign an account key to this issue MET: Plotting Tools MET: Library Code priority: high High Priority labels Aug 16, 2023
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.1.1 (bugfix) milestone Aug 16, 2023
@JohnHalleyGotway JohnHalleyGotway self-assigned this Aug 24, 2023
@JohnHalleyGotway JohnHalleyGotway added the required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone label Nov 30, 2023
@JohnHalleyGotway
Copy link
Collaborator Author

Discussed the status of this issue at the MET development meeting on Feb 22, 2024. @rgbullock is investigating whether this situation can be fixed through the Proj implementation that will be provided in MET version 12.0.0. We'll revisit this next Thursday, Feb 29th, to determine whether its feasible to provide a fix for this in a MET version 11.1.1 bugfix release, or wait to provide the fix as part of the next major release, version 12.0.0.

@JohnHalleyGotway JohnHalleyGotway added alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle and removed required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle MET: Library Code MET: Plotting Tools priority: high High Priority requestor: NOAA/EMC NOAA Environmental Modeling Center type: bug Fix something that is not working
Projects
Development

No branches or pull requests

1 participant