Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Multivariate MODE to read input data only once rather than multiple times #2707

Closed
22 tasks
davidalbo opened this issue Oct 5, 2023 · 1 comment · Fixed by #2779
Closed
22 tasks
Assignees
Labels
component: code optimization Code optimization issue priority: medium Medium Priority type: enhancement Improve something that it is currently doing
Milestone

Comments

@davidalbo
Copy link
Contributor

Replace italics below with details for this issue.

Describe the Enhancement

Current implementation reads data twice ('part1 simple' and 'part1 merge'. Store in memory instead as part of part1 simple, access that in part1 merge.

Time Estimate

24 hours

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

January 16, 2024 (beta3)

Funding Source

NOAA base

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next official version or Backlog of Development Ideas
  • For the next official version, select the MET-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@davidalbo davidalbo added type: enhancement Improve something that it is currently doing type: task An actionable item of work alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle component: code optimization Code optimization issue labels Oct 5, 2023
@davidalbo davidalbo added this to the MET 12.0.0 milestone Oct 5, 2023
@davidalbo davidalbo self-assigned this Oct 5, 2023
@davidalbo davidalbo added priority: medium Medium Priority and removed type: task An actionable item of work alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Oct 5, 2023
@davidalbo davidalbo linked a pull request Feb 8, 2024 that will close this issue
14 tasks
@davidalbo
Copy link
Contributor Author

This issue was resolved in the changes made here: https://github.com/dtcenter/MET/pull/2779. The new design reads in each input only once and keeps it in memory for use in several processing steps.

@JohnHalleyGotway JohnHalleyGotway changed the title Modify Multivariate Mode to read in data only once Enhance Multivariate MODE to read input data only once rather than multiple times Apr 17, 2024
@JohnHalleyGotway JohnHalleyGotway removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: code optimization Code optimization issue priority: medium Medium Priority type: enhancement Improve something that it is currently doing
Projects
Status: 🏁 Done
Development

Successfully merging a pull request may close this issue.

2 participants