From 89a2cff73442b4db2c9da0a8bf41f3a154376724 Mon Sep 17 00:00:00 2001
From: Howard Soh <hsoh@seneca.rap.ucar.edu>
Date: Wed, 19 Apr 2023 16:02:50 -0600
Subject: [PATCH 1/3] #2474 Check the offset

---
 src/tools/other/mode_time_domain/3d_conv.cc | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/tools/other/mode_time_domain/3d_conv.cc b/src/tools/other/mode_time_domain/3d_conv.cc
index 78c54968f0..a2dc208bb7 100644
--- a/src/tools/other/mode_time_domain/3d_conv.cc
+++ b/src/tools/other/mode_time_domain/3d_conv.cc
@@ -529,6 +529,7 @@ void get_data_plane(const MtdFloatFile & mtd, const int t, double * data_plane,
 {
 
 int x, y;
+int offset = 0;
 double * d = data_plane;
 bool * ok = ok_plane;
 double value;
@@ -547,9 +548,13 @@ for (y=0; y<ny; ++y)  {
 
       status = is_bad_data(value);
 
-      *d++ = (float) value;
+      if (offset < (nx * ny)) {
+         *(d+offset) = (float) value;
 
-      *ok++ = ! status;
+         *(ok+offset) = ! status;
+      }
+
+      offset++;
 
    }
 

From c7df68f111995b944a1c445698a625abc459ad75 Mon Sep 17 00:00:00 2001
From: Howard Soh <hsoh@seneca.rap.ucar.edu>
Date: Thu, 20 Apr 2023 11:50:46 -0600
Subject: [PATCH 2/3] #2474 cleanup

---
 src/tools/other/mode_time_domain/3d_conv.cc | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/tools/other/mode_time_domain/3d_conv.cc b/src/tools/other/mode_time_domain/3d_conv.cc
index a2dc208bb7..4598988ef9 100644
--- a/src/tools/other/mode_time_domain/3d_conv.cc
+++ b/src/tools/other/mode_time_domain/3d_conv.cc
@@ -548,11 +548,9 @@ for (y=0; y<ny; ++y)  {
 
       status = is_bad_data(value);
 
-      if (offset < (nx * ny)) {
-         *(d+offset) = (float) value;
+      *(d+offset) = (float) value;
 
-         *(ok+offset) = ! status;
-      }
+      *(ok+offset) = ! status;
 
       offset++;
 

From 60dcd4e37e5703ecb1b64e1908ddb970eb84a250 Mon Sep 17 00:00:00 2001
From: Howard Soh <hsoh@seneca.rap.ucar.edu>
Date: Thu, 20 Apr 2023 12:15:37 -0600
Subject: [PATCH 3/3] #2474 Added comment

---
 src/tools/other/mode_time_domain/3d_conv.cc | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/tools/other/mode_time_domain/3d_conv.cc b/src/tools/other/mode_time_domain/3d_conv.cc
index 4598988ef9..0dd0172f22 100644
--- a/src/tools/other/mode_time_domain/3d_conv.cc
+++ b/src/tools/other/mode_time_domain/3d_conv.cc
@@ -548,9 +548,11 @@ for (y=0; y<ny; ++y)  {
 
       status = is_bad_data(value);
 
-      *(d+offset) = (float) value;
+      if (offset < (nx * ny)) { // kludge for SonarQube findings
+         *(d+offset) = (float) value;
 
-      *(ok+offset) = ! status;
+         *(ok+offset) = ! status;
+      }
 
       offset++;