Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: New way of reading files did not handle files with headers but no data #181

Closed
22 tasks
venitahagerty opened this issue Feb 21, 2023 · 1 comment
Closed
22 tasks
Assignees
Labels
component: load Tasks related to the database loading type: bug Fix something that is not working

Comments

@venitahagerty
Copy link
Contributor

venitahagerty commented Feb 21, 2023

New way of reading files did not handle files with headers but no data

Occasionally, a MET output file will have headers but no data. The code after the change to reading to handle the higher version of Pandas (1.2.3 to 1.5.2) did not handle this problem.

Expected Behavior

Program will give a warning for files with headers and no data, and go on to the next file.

Environment

Describe your runtime environment:
1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop)
2. OS: (e.g. RedHat Linux, MacOS)
3. Software version number(s)

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Organization level Project for support of the current coordinated release
  • Select Repository level Project for development toward the next official release or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Organization level software support Project for the current coordinated release
    Select: Milestone as the next bugfix version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Close this issue.
@venitahagerty venitahagerty added component: load Tasks related to the database loading type: bug Fix something that is not working labels Feb 21, 2023
@venitahagerty venitahagerty self-assigned this Feb 21, 2023
@bikegeek bikegeek modified the milestones: METdataio 2.0.2 (bugfix), METdataio 2.1.0-beta1 Feb 23, 2023
@bikegeek bikegeek modified the milestones: METdataio 2.1.0-beta1, METdataio 2.0.2 (bugfix) Feb 28, 2023
@bikegeek bikegeek moved this from 📋 Backlog to ✅ Done in METplus-Analysis-5.1.0 Development Feb 28, 2023
@bikegeek
Copy link
Collaborator

Testing Summary

Date:
Location:
Status (PASS/FAIL):
Description:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: load Tasks related to the database loading type: bug Fix something that is not working
Projects
Development

No branches or pull requests

2 participants