Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Wrapper: GenEnsProd #1180

Closed
8 of 21 tasks
JohnHalleyGotway opened this issue Sep 28, 2021 · 0 comments · Fixed by #1221 or #1228
Closed
8 of 21 tasks

New Wrapper: GenEnsProd #1180

JohnHalleyGotway opened this issue Sep 28, 2021 · 0 comments · Fixed by #1221 or #1228
Assignees
Labels
alert: NEED MORE DEFINITION Not yet actionable, additional definition required priority: high High Priority requestor: METplus Team METplus Development Team required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: new feature Make it do something new
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Sep 28, 2021

Describe the New Feature

dtcenter/MET#1904 adds an initial version of the new Gen-Ens-Prod tool to the met-10.1.0-beta3 MET development release. This issue adds a wrapper for calling that Gen-Ens-Prod tool. Just like Gen-Ens-Prod is a subset of the Ensemble-Stat tool, it's wrapper can largely be a subset of the existing Ensemble-Stat wrapper.

From @georgemccabe:
The new wrapper will be able to borrow existing components from other wrappers to implement all of the functionality. The wrapper will support the following functionality:

  • Obtain a list of input files, write a file list file, and pass to -ens argument
  • Set environment variables to override values in MET config file (all dictionaries and variables in the new config file are supported in other wrappers)
  • Pass wrapped config file as -config argument
  • Build output file path from template/dir and pass to -out argument
  • Set optional -ctrl path based on template/dir (GEN_ENS_PROD_CTRL_[TEMPLATE/DIR] or GEN_ENS_PROD_CONTROL_[TEMPLATE/DIR])

Acceptance Testing

List input data types and sources.
Describe tests required for new functionality.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the new feature down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2793541

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: @georgemccabe
  • Select scientist(s) or no scientist required: @j-opatz

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

New Feature Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added priority: high High Priority type: new feature Make it do something new alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone labels Sep 28, 2021
@JohnHalleyGotway JohnHalleyGotway added this to the METplus-4.1.0 milestone Sep 28, 2021
@georgemccabe georgemccabe added required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project and removed required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone labels Oct 20, 2021
@georgemccabe georgemccabe removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Oct 21, 2021
@georgemccabe georgemccabe linked a pull request Oct 22, 2021 that will close this issue
12 tasks
@georgemccabe georgemccabe linked a pull request Oct 26, 2021 that will close this issue
@georgemccabe georgemccabe changed the title Add new GenEnsProd wrapper for the new MET tool. New Wrapper: GenEnsProd Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED MORE DEFINITION Not yet actionable, additional definition required priority: high High Priority requestor: METplus Team METplus Development Team required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: new feature Make it do something new
Projects
None yet
3 participants