Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Use Case: Read in precip gauge data for use in METplus with python embedding #1828

Closed
23 tasks
PerryShafran-NOAA opened this issue Sep 22, 2022 · 2 comments · Fixed by #1914
Closed
23 tasks
Assignees
Labels
alert: NEED MORE DEFINITION Not yet actionable, additional definition required priority: high High Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center type: new use case Add a new use case
Milestone

Comments

@PerryShafran-NOAA
Copy link

PerryShafran-NOAA commented Sep 22, 2022

Replace italics below with details for this issue.

Describe the New Use Case

Provide a description of the new feature request here.

Modify METplus to read in the COCORAHS precip gauge data, a CSV file, and use python embedding to allow ASCII2NC to create a file for use in PointStat

Use Case Name and Category

Provide use case name, following Contributor's Guide naming template, and list which category the use case will reside in.

PointStat_fcstURMA_obsCOCORAHS_ASCIIprecip
In the model_applications/precipitation category

If a new category is needed for this use case, provide its name and brief justification

Input Data

List input data types and sources.
Provide a total input file size, keeping necessary data to a minimum.

Acceptance Testing

Describe tests required for new functionality.

Use ASCII2NC and python embedding to create the precip gauge observation file. If this creates a netCDF file that PointStat can read for verification, then the functionality will be successfully created.

As use case develops, provide a run time here

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

1-2 week time is sufficient.

Sub-Issues

Consider breaking the new feature down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

EVS verification code that includes this verification is due to be complete on December 1, 2022.

Funding Source

2773542

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)
  • Select privacy

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

New Use Case Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept your changes. Merge branch into develop.
  • Create a second pull request to merge develop into develop-ref, following the same steps for the first pull request.
  • Delete your fork or branch.
  • Close this issue.
@PerryShafran-NOAA PerryShafran-NOAA added alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle type: new use case Add a new use case labels Sep 22, 2022
@j-opatz j-opatz added this to the METplus-5.0.0 milestone Sep 23, 2022
@j-opatz j-opatz added priority: high High Priority requestor: NOAA/EMC NOAA Environmental Modeling Center and removed alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Sep 23, 2022
@LoganDawson-NOAA
Copy link

Attaching sample file that needs to be read by MET.

CoCoRaHS.20220914.DailyPrecip.csv

@TaraJensen TaraJensen added reporting: DTC NOAA R2O NOAA Research to Operations DTC Project and removed alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels Oct 10, 2022
@j-opatz
Copy link
Contributor

j-opatz commented Oct 12, 2022

The Python embedding script is complete, and the use case should come together quickly now.

@PerryShafran-NOAA and @LoganDawson-NOAA , what type of forecast will the CoCoRaHS data be validating? The use case name only says "ANALYSES", so I wasn't sure. If I can get a copy of the model file you'd like to use to compare to the 2022-09-14 point data you've provided, I can get the use case with ASCII2NC -> PointStat set up.

If you'd like to use a different date, just be sure to send along the observation and model datasets!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED MORE DEFINITION Not yet actionable, additional definition required priority: high High Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center type: new use case Add a new use case
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants