Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StatAnalysis - Support using both init/valid variables in string substitution #1861

Closed
8 of 22 tasks
georgemccabe opened this issue Oct 11, 2022 · 0 comments · Fixed by #1869
Closed
8 of 22 tasks

StatAnalysis - Support using both init/valid variables in string substitution #1861

georgemccabe opened this issue Oct 11, 2022 · 0 comments · Fixed by #1869
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED MORE DEFINITION Not yet actionable, additional definition required component: use case wrapper priority: high High Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: enhancement Improve something that it is currently doing
Milestone

Comments

@georgemccabe
Copy link
Collaborator

georgemccabe commented Oct 11, 2022

Currently the StatAnalysis wrapper only sets certain string substitution templates based on the LOOP_BY setting. If LOOP_BY = INIT, then init_beg and init_end are set, while valid_beg and valid_end are not. If LOOP_BY = VALID, then valid_beg and valid_end are set, while init_beg and init_end are not. @CPKalb has been working on a use case for UAE that needs to loop by init time and it would be less confusing if the output filenames could be named referring to valid time.

Describe the Enhancement

Enhance the StatAnalysis wrapper to compute the begin and end times of the opposite of the LOOP_BY value (e.g. init if valid and valid if init). The minimum and maximum forecast leads specified with FCST_LEAD_LIST and OBS_LEAD_LIST can be used to calculate these values.

Time Estimate

~3 days

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

5.0.0

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required - @CPKalb as needed for testing

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing component: use case wrapper priority: high High Priority alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project labels Oct 11, 2022
@georgemccabe georgemccabe added this to the METplus-5.0.0 milestone Oct 11, 2022
@georgemccabe georgemccabe self-assigned this Oct 11, 2022
@georgemccabe georgemccabe removed the alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle label Oct 11, 2022
@georgemccabe georgemccabe linked a pull request Oct 18, 2022 that will close this issue
14 tasks
@TaraJensen TaraJensen added the reporting: DTC NOAA R2O NOAA Research to Operations DTC Project label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED MORE DEFINITION Not yet actionable, additional definition required component: use case wrapper priority: high High Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: enhancement Improve something that it is currently doing
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants