Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StatAnalysis - Support looping over groups of list items #1870

Closed
19 of 22 tasks
georgemccabe opened this issue Oct 18, 2022 · 0 comments · Fixed by #1869
Closed
19 of 22 tasks

StatAnalysis - Support looping over groups of list items #1870

georgemccabe opened this issue Oct 18, 2022 · 0 comments · Fixed by #1869
Assignees
Labels
component: use case wrapper METplus: Configuration priority: high High Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: METplus Team METplus Development Team required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: enhancement Improve something that it is currently doing
Milestone

Comments

@georgemccabe
Copy link
Collaborator

Currently you can define lists of items that set values in the wrapped StatAnalysisConfig file, such as fcst_lead (FCST_LEAD_LIST), and obs_valid_hour (OBS_VALID_HOUR_LIST). Each of these lists can be added to either LOOP_LIST_ITEMS where each item in the list will be passed to a call to stat_analysis one at a time, or GROUP_LIST_ITEMS where all items in the list will be passed to every call to stat_analysis. There is currently no way to define multiple groups of items to pass into calls to the tool, such as fcst_lead = 0-24, then fcst_lead = 24-48.

Describe the Enhancement

Add support for settings groups of items that can be looped over. For example:

FCST_LEAD_LIST1 = 1,2,3
FCST_LEAD_LIST2 = 4,5,6
LOOP_LIST_ITEMS = FCST_LEAD_LIST

should call stat_analysis once with fcst_lead = [1,2,3];, then call stat_analysis with fcst_lead = [4,5,6];

Time Estimate

~1-2 days

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

5.0.0

Funding Source

None

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required - @CPKalb as needed for testing

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing component: use case wrapper priority: high High Priority requestor: METplus Team METplus Development Team required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project METplus: Configuration labels Oct 18, 2022
@georgemccabe georgemccabe added this to the METplus-5.0.0 milestone Oct 18, 2022
@georgemccabe georgemccabe self-assigned this Oct 18, 2022
@georgemccabe georgemccabe linked a pull request Oct 18, 2022 that will close this issue
14 tasks
@georgemccabe georgemccabe changed the title StatAnalysis - support looping over groups of list items StatAnalysis - Support looping over groups of list items Oct 25, 2022
@TaraJensen TaraJensen added the reporting: DTC NOAA R2O NOAA Research to Operations DTC Project label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: use case wrapper METplus: Configuration priority: high High Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: METplus Team METplus Development Team required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: enhancement Improve something that it is currently doing
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants