Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to stop execution if an app fails #196

Open
georgemccabe opened this issue Feb 28, 2019 · 1 comment
Open

Add option to stop execution if an app fails #196

georgemccabe opened this issue Feb 28, 2019 · 1 comment
Assignees
Labels
alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle component: use case wrapper METplus: Configuration priority: low Low Priority type: new feature Make it do something new

Comments

@georgemccabe
Copy link
Collaborator

This would be useful if you are running a lot of times to be able to see where it failed so you can pick up where you left off. It would also be good for debugging development so you can clearly see when the first issue occurred.

The MET apps return 1 if failure and 0 if success. I believe we already catch this value in the METplus code. We would add a true/false config item (EXIT_ON_FAILURE?) and if true, check the return value and error/exit if the return code is not 0. Checking for not 0 instead of 1 should be used because John mentioned the possibility of changing the MET apps to have different number error codes based on the error.

I would have to look into it (or someone else can chime in) but I believe that most other applications return 0 on success, so we could use this functionality for non-MET apps as well. Some of them may expect to fail sometimes, so if that is the case, we can set a flag to tell METplus to ignore the error code even if EXIT_ON_FAILURE is set.

@georgemccabe
Copy link
Collaborator Author

This would be very easy to implement and would be useful for debugging purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle component: use case wrapper METplus: Configuration priority: low Low Priority type: new feature Make it do something new
Projects
None yet
Development

No branches or pull requests

2 participants