Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more functionality to the custom line feature #375

Open
21 tasks
TatianaBurek opened this issue Feb 17, 2022 · 0 comments
Open
21 tasks

add more functionality to the custom line feature #375

TatianaBurek opened this issue Feb 17, 2022 · 0 comments
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required type: enhancement Improve something that it is currently doing

Comments

@TatianaBurek
Copy link
Collaborator

TatianaBurek commented Feb 17, 2022

Describe the Enhancement

In the PR request John recommended to extend the custom lines functionality and add:

  • Vertical lines for values that do NOT coincide with one of the independent variable values are not plotted (e.g. vertical line at 12 is plotted, but 13 is not).
  • Adding vertical and horizontal lines is good. Would also be nice to add the one-to-one diagonal or perhaps other lines.
  • I understand the color chooser selects lines from a rainbow. If possible, I'd prefer the reference lines be added with a default constant color (like gray) instead of the rainbow. But this is definitely a preference and not a requirement.

Need to evaluate these requests and add them if possible.
METplotpy issue: dtcenter/METplotpy#198

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@TatianaBurek TatianaBurek added type: enhancement Improve something that it is currently doing alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Feb 17, 2022
@TatianaBurek TatianaBurek self-assigned this Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required type: enhancement Improve something that it is currently doing
Projects
None yet
Development

No branches or pull requests

1 participant