Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support inventory macros re-exported by a downstream crate #2

Closed
dtolnay opened this issue Dec 24, 2018 · 1 comment
Closed

Support inventory macros re-exported by a downstream crate #2

dtolnay opened this issue Dec 24, 2018 · 1 comment

Comments

@dtolnay
Copy link
Owner

dtolnay commented Dec 24, 2018

A downstream crate may want to wrap inventory's macros in their own.

gflags::define! {
    /// comma-separated list of languages to offer in the 'lang' menu
    language: &str = "english,french,german";
}

This doesn't work right now because inventory-impl hardcodes inventory as the crate name in generated code.

inventory::submit({ #expr });

Fix is blocked on rust-lang/rust#57089.

@dtolnay
Copy link
Owner Author

dtolnay commented Jan 7, 2019

Implemented a workaround in 5a561d3 and dtolnay/gflags@4e188d3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant