From 93bfc8e75fc62e5adaa881e3da511b1f829318cc Mon Sep 17 00:00:00 2001 From: David Tolnay Date: Fri, 3 Nov 2023 15:10:00 -0700 Subject: [PATCH 1/3] Update test suite to nightly-2023-11-03 --- tests/repo/mod.rs | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/tests/repo/mod.rs b/tests/repo/mod.rs index 61d5ff35f4..c7920fb857 100644 --- a/tests/repo/mod.rs +++ b/tests/repo/mod.rs @@ -13,10 +13,24 @@ use std::path::{Path, PathBuf}; use tar::Archive; use walkdir::{DirEntry, WalkDir}; -const REVISION: &str = "9f5fc1bd443f59583e7af0d94d289f95fe1e20c4"; +const REVISION: &str = "a2f5f9691b6ce64c1703feaf9363710dfd7a56cf"; #[rustfmt::skip] static EXCLUDE_FILES: &[&str] = &[ + // TODO + "src/tools/clippy/tests/ui/needless_raw_string.rs", + "src/tools/clippy/tests/ui/needless_raw_string_hashes.rs", + "src/tools/rustfmt/tests/source/issue_5721.rs", + "src/tools/rustfmt/tests/source/non-lifetime-binders.rs", + "src/tools/rustfmt/tests/target/issue_5721.rs", + "src/tools/rustfmt/tests/target/non-lifetime-binders.rs", + "tests/rustdoc/inline_cross/auxiliary/non_lifetime_binders.rs", + "tests/rustdoc/typedef-inner-variants-lazy_type_alias.rs", + "tests/ui/coroutine/gen_block_is_iter.rs", + "tests/ui/coroutine/gen_block_iterate.rs", + "tests/ui/parser/struct-literal-in-match-guard.rs", + "tests/ui/unreachable-code.rs", + // TODO: CStr literals: c"…", cr"…" // https://github.com/dtolnay/syn/issues/1502 "src/tools/rust-analyzer/crates/parser/test_data/parser/inline/ok/0085_expr_literals.rs", @@ -108,9 +122,6 @@ static EXCLUDE_FILES: &[&str] = &[ "tests/ui/lifetimes/bare-trait-object.rs", "tests/ui/parser/bounds-obj-parens.rs", - // Obsolete box syntax - "src/tools/rust-analyzer/crates/parser/test_data/parser/inline/ok/0132_box_expr.rs", - // Invalid unparenthesized range pattern inside slice pattern: `[1..]` "tests/ui/consts/miri_unleashed/const_refers_to_static_cross_crate.rs", From aadbe5a280be1808dd68ce056233163dc060b76e Mon Sep 17 00:00:00 2001 From: David Tolnay Date: Sun, 5 Nov 2023 13:22:18 -0800 Subject: [PATCH 2/3] Categorize newly failing rust repo source files --- tests/repo/mod.rs | 34 ++++++++++++++++++++-------------- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/tests/repo/mod.rs b/tests/repo/mod.rs index c7920fb857..fd497f058c 100644 --- a/tests/repo/mod.rs +++ b/tests/repo/mod.rs @@ -17,22 +17,10 @@ const REVISION: &str = "a2f5f9691b6ce64c1703feaf9363710dfd7a56cf"; #[rustfmt::skip] static EXCLUDE_FILES: &[&str] = &[ - // TODO - "src/tools/clippy/tests/ui/needless_raw_string.rs", - "src/tools/clippy/tests/ui/needless_raw_string_hashes.rs", - "src/tools/rustfmt/tests/source/issue_5721.rs", - "src/tools/rustfmt/tests/source/non-lifetime-binders.rs", - "src/tools/rustfmt/tests/target/issue_5721.rs", - "src/tools/rustfmt/tests/target/non-lifetime-binders.rs", - "tests/rustdoc/inline_cross/auxiliary/non_lifetime_binders.rs", - "tests/rustdoc/typedef-inner-variants-lazy_type_alias.rs", - "tests/ui/coroutine/gen_block_is_iter.rs", - "tests/ui/coroutine/gen_block_iterate.rs", - "tests/ui/parser/struct-literal-in-match-guard.rs", - "tests/ui/unreachable-code.rs", - // TODO: CStr literals: c"…", cr"…" // https://github.com/dtolnay/syn/issues/1502 + "src/tools/clippy/tests/ui/needless_raw_string.rs", + "src/tools/clippy/tests/ui/needless_raw_string_hashes.rs", "src/tools/rust-analyzer/crates/parser/test_data/parser/inline/ok/0085_expr_literals.rs", // TODO: explicit tail calls: `become _g()` @@ -41,7 +29,12 @@ static EXCLUDE_FILES: &[&str] = &[ // TODO: non-lifetime binders: `where for<'a, T> &'a Struct: Trait` // https://github.com/dtolnay/syn/issues/1435 + "src/tools/rustfmt/tests/source/issue_5721.rs", + "src/tools/rustfmt/tests/source/non-lifetime-binders.rs", + "src/tools/rustfmt/tests/target/issue_5721.rs", + "src/tools/rustfmt/tests/target/non-lifetime-binders.rs", "tests/rustdoc-json/non_lifetime_binders.rs", + "tests/rustdoc/inline_cross/auxiliary/non_lifetime_binders.rs", "tests/rustdoc/non_lifetime_binders.rs", // TODO: return type notation: `where T: Trait` @@ -50,6 +43,19 @@ static EXCLUDE_FILES: &[&str] = &[ "tests/ui/associated-type-bounds/return-type-notation/basic.rs", "tests/ui/feature-gates/feature-gate-return_type_notation.rs", + // TODO: lazy type alias syntax with where-clause in trailing position + "tests/rustdoc/typedef-inner-variants-lazy_type_alias.rs", + + // TODO: gen blocks and functions + "tests/ui/coroutine/gen_block_is_iter.rs", + "tests/ui/coroutine/gen_block_iterate.rs", + + // TODO: struct literal in match guard + "tests/ui/parser/struct-literal-in-match-guard.rs", + + // TODO: precedence of return in match guard + "tests/ui/unreachable-code.rs", + // Compile-fail expr parameter in const generic position: f::<1 + 2>() "tests/ui/const-generics/early/closing-args-token.rs", "tests/ui/const-generics/early/const-expression-parameter.rs", From ee3cc8f62aa9323f30c4332911d367c2e152d073 Mon Sep 17 00:00:00 2001 From: David Tolnay Date: Sun, 5 Nov 2023 13:45:42 -0800 Subject: [PATCH 3/3] Record issues for new syntax gaps --- tests/repo/mod.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/repo/mod.rs b/tests/repo/mod.rs index fd497f058c..aa385a1d49 100644 --- a/tests/repo/mod.rs +++ b/tests/repo/mod.rs @@ -44,16 +44,20 @@ static EXCLUDE_FILES: &[&str] = &[ "tests/ui/feature-gates/feature-gate-return_type_notation.rs", // TODO: lazy type alias syntax with where-clause in trailing position + // https://github.com/dtolnay/syn/issues/1525 "tests/rustdoc/typedef-inner-variants-lazy_type_alias.rs", // TODO: gen blocks and functions + // https://github.com/dtolnay/syn/issues/1526 "tests/ui/coroutine/gen_block_is_iter.rs", "tests/ui/coroutine/gen_block_iterate.rs", // TODO: struct literal in match guard + // https://github.com/dtolnay/syn/issues/1527 "tests/ui/parser/struct-literal-in-match-guard.rs", // TODO: precedence of return in match guard + // https://github.com/dtolnay/syn/issues/1528 "tests/ui/unreachable-code.rs", // Compile-fail expr parameter in const generic position: f::<1 + 2>()