Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new feature for the calculation of thermochemical contributions #289

Closed
IannLiu opened this issue Aug 11, 2023 · 0 comments · Fixed by #292 or #308
Closed

A new feature for the calculation of thermochemical contributions #289

IannLiu opened this issue Aug 11, 2023 · 0 comments · Fixed by #292 or #308
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@IannLiu
Copy link

IannLiu commented Aug 11, 2023

Hi, Tom I recommend a new feature for the calculation of thermochemical contributions.
The qRRHO treatment proposed by Grimme only applies to entropy. Recently, another paper (J. Comput. Chem., 44, 1807 (2023)) proved that using Grimme's scheme to calculate the enthalpy contribution will ensure the internal consistency and improve the quality of Gibbs free energies (ΔGr).

This approach can be easily realized by incorporating a few lines of code. For example:

U_free_rotor = 0.5 * SIConstants.k_b * temp
U_qRRHO = w * U_RROH + (1 - w) * U_free_rotor

where U_RROH is the internal energy from vibrational motion and w is calculated by (line 378 in autode.thermochemistry.igm.py):
w = 1.0 / (1.0 + (omega_0 / freq) ** alpha)

@t-young31 t-young31 added the enhancement New feature or request label Aug 13, 2023
@t-young31 t-young31 added this to the v1.4.1 milestone Aug 19, 2023
@t-young31 t-young31 mentioned this issue Aug 19, 2023
4 tasks
@t-young31 t-young31 self-assigned this Aug 19, 2023
@t-young31 t-young31 linked a pull request Aug 20, 2023 that will close this issue
4 tasks
@t-young31 t-young31 linked a pull request Oct 31, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants