Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Take advantage of newly introduced HeightField in hppfcl #489

Open
duburcqa opened this issue Mar 19, 2022 · 3 comments
Open

[core] Take advantage of newly introduced HeightField in hppfcl #489

duburcqa opened this issue Mar 19, 2022 · 3 comments
Labels
core enhancement New feature or request P0 Highest priority issue physics

Comments

@duburcqa
Copy link
Owner

Proper support of heigthmap has been added to hpp-fcl. It should be used in place of the current implementation of collision detection. It would be more generic than the current implementation, and hopefully still efficient. However, it requires discretizing the ground profile, which is not necessary for now. It would also prevent relying on a hack to render the ground.

@duburcqa duburcqa added new feature physics core P0 Highest priority issue labels Apr 2, 2022
@duburcqa duburcqa added enhancement New feature or request and removed new feature labels May 1, 2022
@duburcqa
Copy link
Owner Author

duburcqa commented May 16, 2023

It would also be nice to use pre-allocated distance / collision functors as described here

@duburcqa duburcqa changed the title Take advantage of newly introduced HeightField in hppfcl [core] Take advantage of newly introduced HeightField in hppfcl Aug 10, 2023
@duburcqa duburcqa moved this to To do in Jiminy 1.9 Oct 26, 2023
@duburcqa
Copy link
Owner Author

duburcqa commented Feb 2, 2024

Ground profile height map can now be converted into heightmap in C++ core. There is both a slowdown and a accuracy loss of doing so but it is the price to pay. The current implementation generate a regular heightmap first for some prescribed x and y grid unit, then eventually it is decimated afterward. Decimation has no effect on accuracy but conversion to regular map has.

@duburcqa
Copy link
Owner Author

duburcqa commented Feb 2, 2024

I suggest modifying the existing GroundProfile engine option, which is for now working on symbolic heightmap functions, to rather operate on hppfcl::collisionObject instances directly. This way, the slowdown and accuracy loss would not be a simulation concern but rather a user concern. Generation could be done only once, at first instantiation of the environment rather than every reset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core enhancement New feature or request P0 Highest priority issue physics
Projects
Status: To do
Development

No branches or pull requests

1 participant