Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add option to produce non-integer on double #4917

Merged
merged 2 commits into from
Apr 24, 2024
Merged

✨ Add option to produce non-integer on double #4917

merged 2 commits into from
Apr 24, 2024

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Apr 24, 2024

Related to #4831

I still have a bit of refinement to do around it, but I'll do in next PRs:

  • produced range is still too large
  • no integration layer for tests
  • floats

Category:

  • ✨ Introduce new features
  • 📝 Add or update documentation
  • ✅ Add or update tests
  • 🐛 Fix a bug
  • 🏷️ Add or update types
  • ⚡️ Improve performance
  • Other(s): ...

Potential impacts:

  • Generated values
  • Shrink values
  • Performance
  • Typings
  • Other(s): ...

Related to #4831

I still have a bit of refinement to do around it, but I'll do in next PRs:

- produced range is still too large
- no integration layer for tests
- floats
Copy link

codesandbox-ci bot commented Apr 24, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0b81bde:

Sandbox Source
@fast-check/examples Configuration

Copy link
Contributor

👋 A preview of the new documentation is available at: http://6628afe130be9c856b800324--dubzzz-fast-check.netlify.app

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 81.48148% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 96.78%. Comparing base (6824385) to head (0b81bde).
Report is 15 commits behind head on main.

Files Patch % Lines
.../arbitrary/_internals/helpers/DoubleOnlyHelpers.ts 80.88% 13 Missing ⚠️
packages/fast-check/src/arbitrary/double.ts 82.50% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4917      +/-   ##
==========================================
- Coverage   96.88%   96.78%   -0.11%     
==========================================
  Files         210      211       +1     
  Lines       16117    16213      +96     
  Branches     2619     2637      +18     
==========================================
+ Hits        15615    15691      +76     
- Misses        502      522      +20     
Flag Coverage Δ
unit-tests 96.78% <81.48%> (-0.11%) ⬇️
unit-tests-18.x-Linux 96.78% <81.48%> (-0.11%) ⬇️
unit-tests-20.x-Linux 96.78% <81.48%> (-0.11%) ⬇️
unit-tests-latest-Linux 96.78% <81.48%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dubzzz dubzzz merged commit 2dec597 into main Apr 24, 2024
67 of 69 checks passed
@dubzzz dubzzz deleted the non-int-double branch April 24, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant