From 018aabb101afaab23fe9914480dda53462ecfdf4 Mon Sep 17 00:00:00 2001
From: Mark Raasveldt <mark.raasveldt@gmail.com>
Date: Tue, 3 Sep 2024 19:26:18 +0200
Subject: [PATCH] Fix #242: correctly reset varchar chunk when casting data in
 CopyChunk

---
 src/postgres_copy_to.cpp                      |  2 ++
 .../storage/attach_varchar_list_nulls.test    | 32 +++++++++++++++++++
 2 files changed, 34 insertions(+)
 create mode 100644 test/sql/storage/attach_varchar_list_nulls.test

diff --git a/src/postgres_copy_to.cpp b/src/postgres_copy_to.cpp
index d0189d5d..6479e4c8 100644
--- a/src/postgres_copy_to.cpp
+++ b/src/postgres_copy_to.cpp
@@ -282,6 +282,8 @@ void PostgresConnection::CopyChunk(ClientContext &context, PostgresCopyState &st
 				varchar_types.push_back(LogicalType::VARCHAR);
 			}
 			varchar_chunk.Initialize(Allocator::DefaultAllocator(), varchar_types);
+		} else {
+			varchar_chunk.Reset();
 		}
 		D_ASSERT(chunk.ColumnCount() == varchar_chunk.ColumnCount());
 		// for text format cast to varchar first
diff --git a/test/sql/storage/attach_varchar_list_nulls.test b/test/sql/storage/attach_varchar_list_nulls.test
new file mode 100644
index 00000000..7423c7b0
--- /dev/null
+++ b/test/sql/storage/attach_varchar_list_nulls.test
@@ -0,0 +1,32 @@
+# name: test/sql/storage/attach_varchar_list_nulls.test
+# description: Test inserting/querying VARCHAR lists with NULL values
+# group: [storage]
+
+require postgres_scanner
+
+require-env POSTGRES_TEST_DATABASE_AVAILABLE
+
+statement ok
+PRAGMA enable_verification
+
+statement ok
+ATTACH 'dbname=postgresscanner' AS s (TYPE POSTGRES)
+
+statement ok
+CREATE OR REPLACE TABLE s.varchar_list_big(i BIGINT, v VARCHAR[]);
+
+statement ok
+CREATE TABLE tbl AS SELECT CASE WHEN i<1000 THEN NULL ELSE i END i, case when i<1000 then null else [i] end v FROM range(4000) t(i);
+
+query IIII
+select min(len(v)), max(len(v)), sum(len(v)), count(*) from tbl;
+----
+1	1	3000	4000
+
+statement ok
+INSERT INTo s.varchar_list_big FROM tbl
+
+query IIII
+select min(len(v)), max(len(v)), sum(len(v)), count(*) from s.varchar_list_big;
+----
+1	1	3000	4000