Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp wrapper type #105

Merged
merged 6 commits into from
Dec 12, 2022
Merged

Add timestamp wrapper type #105

merged 6 commits into from
Dec 12, 2022

Conversation

0b01
Copy link
Contributor

@0b01 0b01 commented Dec 10, 2022

This PR adds a Timestamp wrapper type for appending timestamps in the appender. This should be the lowest overhead way for inserting timestamps.

@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Merging #105 (d2f1037) into main (d2f611f) will increase coverage by 0.10%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   59.47%   59.57%   +0.10%     
==========================================
  Files          26       26              
  Lines        1451     1467      +16     
==========================================
+ Hits          863      874      +11     
- Misses        588      593       +5     
Impacted Files Coverage Δ
src/appender.rs 70.00% <50.00%> (-2.73%) ⬇️
src/statement.rs 74.15% <50.00%> (-1.75%) ⬇️
src/types/to_sql.rs 86.48% <100.00%> (+1.63%) ⬆️
src/types/value_ref.rs 40.24% <0.00%> (+1.21%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@wangfenjin wangfenjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! There is one comment bellow

src/types/mod.rs Outdated Show resolved Hide resolved
0b01 and others added 3 commits December 11, 2022 20:36
Change-Id: Ia1df252ab09ec93680d9f1e6a3dba196c6dfe478
@wangfenjin wangfenjin merged commit e666e08 into duckdb:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants