Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove buildtime_bindgen from bundled feature #119

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Conversation

rkusa
Copy link
Contributor

@rkusa rkusa commented Feb 8, 2023

The README mentioned that you get pregenerated bindings if the bundled feature is used:

If you use the bundled features, you will get pregenerated bindings for the bundled version of DuckDB. If you want to run bindgen at buildtime to produce your own bindings, use the buildtime_bindgen Cargo feature.

However, 2a50047 added the buildtime_bindgen to the bundled feature. So this statement doesn't hold true anymore.

This PR removes buildtime_bindgen from the bundled feature again, just in case including it wasn't on purpose. Otherwise, I'd like to suggest a README update instead 😊.

@wangfenjin wangfenjin merged commit 1f94f19 into duckdb:main Feb 9, 2023
@wangfenjin
Copy link
Collaborator

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants