Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile from source on Windows #65

Merged
merged 21 commits into from
Jul 24, 2022
Merged

Compile from source on Windows #65

merged 21 commits into from
Jul 24, 2022
+82 −32

Conversation

wangfenjin
Copy link
Collaborator

@wangfenjin wangfenjin commented Jul 24, 2022 •
edited
Loading

Based on #63

Close #62 #63

Michael-F-Bryan and others added 13 commits June 30, 2022 23:37
Let the cc crate use its default behaviour for -fPIC
2c4276f
@Michael-F-Bryan
Make sure we pass "/bigobj" when compiling with the MSVC compiler
64a5dd9
@Michael-F-Bryan
Fix type error because DuckDB constants were inferred to be i32 on Wi…
8964712 
…ndows
@Michael-F-Bryan
Use the "duckdb_state" typedef instead of assuming it'll always be c_…
0f61110 
…uint
@Michael-F-Bryan
Make sure we define "DUCKDB_BUILD_LIBRARY" to set dllexport and friends
2da510a
@Michael-F-Bryan
Windows doesn't allow concurrent writes to a file
60def74
@Michael-F-Bryan
Re-enable Windows builds
9c22b49
@dependabot @wangfenjin
Update arrow requirement from 17 to 18 (#64)
3853626 
* Update arrow requirement from 17 to 18

Updates the requirements on [arrow](https://github.com/apache/arrow-rs) to permit the latest version.
- [Release notes](https://github.com/apache/arrow-rs/releases)
- [Changelog](https://github.com/apache/arrow-rs/blob/master/CHANGELOG.md)
- [Commits](apache/arrow-rs@17.0.0...18.0.0)

---
updated-dependencies:
- dependency-name: arrow
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix build error

Change-Id: I252a9021ef57cbcb82e5122f30754415085718c8

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: wangfenjin <wangfenj@gmail.com>
@wangfenjin
use action to download and extract
9937626 
Change-Id: Ia2057bdf3dad686aa07b64f38cce20faa6d9a898
@wangfenjin
fix filepath
7ad5461 
Change-Id: I91c5abcad6460051000dea430373cf64d7bc44bb
@wangfenjin
fix windows
d0fde57 
Change-Id: If0d2dad8c889f6df387550f96712681f63c16c9c
@wangfenjin
fix windows
93768ed 
Change-Id: Ia43544c3683bc6418eddf4e971413d621d629a89
@wangfenjin
static set windows
fd237f9 
Change-Id: I685ff5f761ff0e342bc9afeb053df48ec28f1ad2
@codecov
Copy link

codecov bot commented Jul 24, 2022 •
edited
Loading

Codecov Report

Merging #65 (37acf77) into main (30d8e3e) will not change coverage.
The diff coverage is 77.77%.

@@           Coverage Diff           @@
##             main      #65   +/-   ##
=======================================
  Coverage   76.01%   76.01%           
=======================================
  Files          25       25           
  Lines        2502     2502           
=======================================
  Hits         1902     1902           
  Misses        600      600
Impacted Files Coverage Δ
src/config.rs 96.38% <0.00%> (ø)
src/lib.rs 90.54% <ø> (ø)
src/row.rs 66.14% <ø> (ø)
src/statement.rs 89.73% <ø> (ø)
libduckdb-sys/src/error.rs 14.28% <50.00%> (ø)
src/error.rs 24.46% <100.00%> (ø)
src/inner_connection.rs 85.24% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@wangfenjin
windows
359def9 
Change-Id: I91c9f7325de3de5767baf462d1ac681931c3ab95
@wangfenjin
fix
db395d5 
Change-Id: Ic8cc0833a7fad865b1c7b671518da043ffb02d57
@wangfenjin
fix
5a59c78 
Change-Id: Ib9a4dc6af13fbe39eff78dd849614b3285690dfe
@wangfenjin
fix cargo test
5aac7dc 
Change-Id: I3b3f5726507e4a9c94188994fe533ee335c4192e
@wangfenjin
use path
394a9f7 
Change-Id: I1bf94c209ad65637be945c5d0a81a640da798f57
@wangfenjin
set path
8c543c1 
Change-Id: I86957007844bc9e20ed2829d04e731176ac5e3ae
@wangfenjin
Add windows build from source
c739512 
Change-Id: I3d45e79e61b49690a6a58756ccc8b7fb3abcc153
@wangfenjin
fix test
37acf77 
Change-Id: Ibffbe97225c5d807bb2eaf4b7f80e807b9634405
@wangfenjin wangfenjin changed the title Windows builds Compile from source on Windows #63 Jul 24, 2022
@wangfenjin wangfenjin changed the title Compile from source on Windows #63 Compile from source on Windows Jul 24, 2022
@wangfenjin wangfenjin merged commit 213b1a5 into main Jul 24, 2022
@wangfenjin wangfenjin deleted the windows-builds branch July 24, 2022 08:44
This was referenced Jul 24, 2022
Closed
Open
@wangfenjin wangfenjin added the feature Used for auto generate changelog label Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature Used for auto generate changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to compile duckdb-sys on Windows
2 participants
@wangfenjin @Michael-F-Bryan