-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump 0.4.0 -> 0.5.0 #77
Conversation
Signed-off-by: Pradeep Chhetri <pradeepchhetri4444@gmail.com>
Hi @chhetripradeep , thank you so much for working on this. The CI might report some error, please help follow up. You can run |
Hi @wangfenjin Thank you for the quick review. Sure, I will follow up on the error. |
Acctually when I prepare the upgrade, I found an issue duckdb/duckdb#4612 , although it's fixed in master version, but still the 0.5.0 version will break the test, fixing it you can just delete the So recently I'm hesitate if we still publish the new version... But as you create this PR, I think I'll still publish the new version. |
Also you noticed that #76 arrow dependency also break because of apache/arrow-rs#2659 So if I release the new version, may stick to 21 for now. |
I struggle a lot about this haha... |
For test_ddl can change to these fn test_ddl() -> Result<()> { [27/2402]
let db = Connection::open_in_memory()?;
db.execute_batch(
r#"
CREATE TABLE foo (x INT);
INSERT INTO foo VALUES (1);
"#,
)?;
let sql = "SELECT * FROM foo";
{
let mut stmt = db.prepare_cached(sql)?;
assert_eq!(Ok(Some(1i32)), stmt.query([])?.map(|r| r.get(0)).next());
}
db.execute_batch(
r#"
ALTER TABLE foo ADD COLUMN y INT;
UPDATE foo SET y = 2;
"#,
)?;
{
// Rebinding statement after catalog change resulted in change of types
let mut stmt = db.prepare_cached(sql)?;
assert_eq!(
Ok(Some((1i32, 2i32))),
stmt.query([])?.map(|r| <(i32, i32)>::try_from(r)).next()
);
}
Ok(())
} |
Thank you for the help |
Codecov Report
@@ Coverage Diff @@
## main #77 +/- ##
==========================================
- Coverage 74.02% 73.93% -0.09%
==========================================
Files 26 26
Lines 2810 2805 -5
==========================================
- Hits 2080 2074 -6
- Misses 730 731 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
DuckDB 0.5.0 was released recently https://github.com/duckdb/duckdb/releases/tag/v0.5.0
Used upgrade.sh script for this PR.