Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump 0.4.0 -> 0.5.0 #77

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Conversation

chhetripradeep
Copy link
Contributor

DuckDB 0.5.0 was released recently https://github.com/duckdb/duckdb/releases/tag/v0.5.0

Used upgrade.sh script for this PR.

Signed-off-by: Pradeep Chhetri <pradeepchhetri4444@gmail.com>
@wangfenjin
Copy link
Collaborator

Hi @chhetripradeep , thank you so much for working on this. The CI might report some error, please help follow up.

You can run cargo test --features bundled --features modern-full -- --nocapture locally to find the breaking test.

@chhetripradeep
Copy link
Contributor Author

Hi @wangfenjin Thank you for the quick review. Sure, I will follow up on the error.

@wangfenjin
Copy link
Collaborator

Acctually when I prepare the upgrade, I found an issue duckdb/duckdb#4612 , although it's fixed in master version, but still the 0.5.0 version will break the test, fixing it you can just delete the where id = clause for now.

So recently I'm hesitate if we still publish the new version... But as you create this PR, I think I'll still publish the new version.

@wangfenjin
Copy link
Collaborator

Also you noticed that #76 arrow dependency also break because of apache/arrow-rs#2659

So if I release the new version, may stick to 21 for now.

@wangfenjin
Copy link
Collaborator

I struggle a lot about this haha...

@wangfenjin
Copy link
Collaborator

For test_ddl can change to these

    fn test_ddl() -> Result<()> {                                                                                                                                                                [27/2402]
        let db = Connection::open_in_memory()?;
        db.execute_batch(
            r#"
            CREATE TABLE foo (x INT);
            INSERT INTO foo VALUES (1);
        "#,
        )?;

        let sql = "SELECT * FROM foo";

        {
            let mut stmt = db.prepare_cached(sql)?;
            assert_eq!(Ok(Some(1i32)), stmt.query([])?.map(|r| r.get(0)).next());
        }

        db.execute_batch(
            r#"
            ALTER TABLE foo ADD COLUMN y INT;
            UPDATE foo SET y = 2;
        "#,
        )?;

        {
            // Rebinding statement after catalog change resulted in change of types
            let mut stmt = db.prepare_cached(sql)?;
            assert_eq!(
                Ok(Some((1i32, 2i32))),
                stmt.query([])?.map(|r| <(i32, i32)>::try_from(r)).next()
            );
        }
        Ok(())
    }

Signed-off-by: Pradeep Chhetri <pradeepchhetri4444@gmail.com>
@chhetripradeep
Copy link
Contributor Author

Thank you for the help

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #77 (2a0a4fb) into main (5b72aa7) will decrease coverage by 0.08%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   74.02%   73.93%   -0.09%     
==========================================
  Files          26       26              
  Lines        2810     2805       -5     
==========================================
- Hits         2080     2074       -6     
- Misses        730      731       +1     
Impacted Files Coverage Δ
src/cache.rs 93.07% <75.00%> (-1.00%) ⬇️
src/types/to_sql.rs 96.12% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wangfenjin wangfenjin merged commit 3a6f966 into duckdb:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants