Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client displays correct subscription #1088

Merged
merged 32 commits into from
Nov 29, 2024

Conversation

miasma13
Copy link
Contributor

@miasma13 miasma13 commented Nov 21, 2024

Required:

Task/Issue URL: https://app.asana.com/0/1208524871249522/1208379950230747/f
iOS PR: duckduckgo/iOS#3620
macOS PR: duckduckgo/macos-browser#3581
What kind of version bump will this require?: Minor

Description:
See https://app.asana.com/0/1208524871249522/1208379950230747/f

Steps to test this PR:
See client PRs

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons self-requested a review November 25, 2024 20:53
@miasma13 miasma13 marked this pull request as ready for review November 28, 2024 18:31
@miasma13 miasma13 force-pushed the michal/non-us-subscriptions branch from 2320cd7 to 85fd7e8 Compare November 29, 2024 10:43
@miasma13 miasma13 changed the base branch from main to hotfix/211.1.3-1 November 29, 2024 10:44
@miasma13 miasma13 merged commit 114cdbf into hotfix/211.1.3-1 Nov 29, 2024
7 checks passed
@miasma13 miasma13 deleted the michal/non-us-subscriptions branch November 29, 2024 10:49
samsymons added a commit that referenced this pull request Nov 29, 2024
* main:
  Add Privacy Stats module for collecting stats about blocked trackers (#1097)
  experiment framework (#1100)
  Client displays correct subscription (#1088)
  Bump github.com/duckduckgo/privacy-dashboard from 7.2.0 to 7.2.1 (#1085)
samsymons added a commit that referenced this pull request Nov 30, 2024
* main:
  Add `locale` parameter to RMF survey builder (#1105)
  Add Privacy Stats module for collecting stats about blocked trackers (#1097)
  experiment framework (#1100)
  Client displays correct subscription (#1088)
  Bump github.com/duckduckgo/privacy-dashboard from 7.2.0 to 7.2.1 (#1085)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants