Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add locale parameter to RMF survey builder #1105

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Add locale parameter to RMF survey builder #1105

merged 4 commits into from
Nov 29, 2024

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Nov 29, 2024 •
edited
Loading

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/1199333091098016/1208868981778301/f
iOS PR: duckduckgo/iOS#3648
macOS PR: duckduckgo/macos-browser#3613
What kind of version bump will this require?: Patch

Description:

Steps to test this PR:

  1. Check that the parameter logic looks good and that the new unit test suite correctly checks it

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12
Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons mentioned this pull request Nov 29, 2024
Merged
11 tasks
@samsymons samsymons mentioned this pull request Nov 29, 2024
Merged
2 tasks
@samsymons samsymons requested a review from ayoy November 29, 2024 02:45
@samsymons
Merge branch 'main' into sam/add-rmf-survey-locale-parameter
7b6349d 
* main:
  Add Privacy Stats module for collecting stats about blocked trackers (#1097)
  experiment framework (#1100)
  Client displays correct subscription (#1088)
  Bump github.com/duckduckgo/privacy-dashboard from 7.2.0 to 7.2.1 (#1085)
@samsymons
Add additional test.
2a7b6d3
@Bunn Bunn self-requested a review November 29, 2024 21:13
@samsymons samsymons merged commit 837dfbf into main Nov 29, 2024
8 checks passed
@samsymons samsymons deleted the sam/add-rmf-survey-locale-parameter branch November 29, 2024 23:39
samsymons added a commit that referenced this pull request Nov 30, 2024
@samsymons
Merge branch 'main' into sam/remove-malformed-error-pixel
08ca77b 
* main:
  Add `locale` parameter to RMF survey builder (#1105)
  Add Privacy Stats module for collecting stats about blocked trackers (#1097)
  experiment framework (#1100)
  Client displays correct subscription (#1088)
  Bump github.com/duckduckgo/privacy-dashboard from 7.2.0 to 7.2.1 (#1085)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bunn Bunn Bunn approved these changes

@ayoy ayoy Awaiting requested review from ayoy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsymons @Bunn