Fix bookmarks toolbar behaviour with Sync Promo on iOS 15 #3313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amddg44
commented
Sep 4, 2024
| @@ -8,5 +8,8 @@ | |||
| "info" : { | |||
| "author" : "xcode", | |||
| "version" : 1 | |||
| }, | |||
There was a problem hiding this comment.
I noticed while testing that this icon colour wasn’t updating with dark mode 🙂
amddg44
commented
Sep 4, 2024
| @@ -920,9 +924,6 @@ class BookmarksViewController: UIViewController, UITableViewDelegate { | |||
| headerView.frame = CGRect(x: 0, y: 0, width: tableView.bounds.width, height: totalHeight) | |||
|
|
|||
| tableView.tableHeaderView = headerView | |||
| syncPromoViewHostingController.didMove(toParent: self) | |||
|
|
|||
| tableView.layoutIfNeeded() | |||
There was a problem hiding this comment.
Removed tableView.layoutIfNeeded() as it turned out to not be needed
dus7
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
LGTM. I also started sync e2e test to verify it passes here, so let's wait for it to finish.
samsymons
added a commit
that referenced
this pull request
Sep 9, 2024
# By Christopher Brind (4) and others # Via Alessandro Boron (1) and others * main: (27 commits) Bump C-S-S to 6.14.1 (#3331) DuckPlayer Launch Experiment for iOS (#3328) defer loading the tab switcher button until view did load (#3326) Release 7.136.0-3 (#3324) Release PR: Check for the negative attribution case (#3311) fix tab switcher crashes (speculative fix) (#3319) Onboarding highlights feature flag setup (#3308) Release 7.136.0-2 (#3320) Attempt to fix dissapearing privacy icon (#3317) Fix bookmarks toolbar behaviour with Sync Promo on iOS 15 (#3313) Bump BSK with C-S-S to 6.14.0 (#3314) ensure no atb or app version sent with pixel (#3315) Fix #3298: Add support for Xcode 16 (#3299) Fix Keychain Debug view controller segue (#3310) Release 7.136.0-1 (#3309) Fix an issue that causes the fire dialog to show multiple times for the same website after dismissing it (#3305) [DuckPlayer] 28. Open in Youtube -> Youtube App (#3290) usage segmentation (#3263) Fix wrong URL displayed for auth dialog (#3307) iOS Integration of BSK Onboarding (#3282) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414709148257752/1208220515829639/f
Tech Design URL:
CC:
Description:
Fixes a SwiftUI issue which caused the toolbar to not appear correctly on the bookmarks screen
Steps to test this PR:
Note: The visibility of the Sync Promo can be reset from the debug screen (final row on that screen)
Definition of Done (Internal Only):
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
—
Internal references:
Software Engineering Expectations
Technical Design Template