move daily text zoom pixel to same location as count pixel #3666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brindy
changed the title
Bunn
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
First time:
Pixel fired m.menu.page.zoom.taps
Pixel fired m.menu.page.zoom.changed.daily
Pixel fired m.menu.page.zoom.changed ["text_size_updated": "120", "text_size_initial": "100"]
Second time
Pixel fired m.menu.page.zoom.taps
Pixel fired m.menu.page.zoom.changed ["text_size_initial": "120", "text_size_updated": "100"]
|
Cherry picked this on to the hotfix. Thanks @Bunn |
samsymons
added a commit
that referenced
this pull request
Dec 5, 2024
* main: Release 7.148.0-2 (#3676) Merge hotfix changes from 7.147.1 (#3674) Add `install` pixel (#3656) AI Chat browsing menu (#3635) Release 7.147.1-0 (#3672) Use actor isolation for `SubscriptionFeatureMappingCache` (#3670) cherry picked - already approved in #3666 fix suggestion scrolling (#3654) Update autoconsent to v12.1.0 (#3650) Malware protection: bump BSK (#3617) Release 7.148.0-1 (#3661) Make a simple state machine to identify incorrect transitions (#3660) support local storage fireproofing (#3612) Make NTP Grid layout adaptive for various screen sizes (#3657) Release 7.148.0-0 (#3659) Bump BSK, add Free Trials Feature Flag (#3655)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/392891325557410/1208890374564365/f
Tech Design URL:
CC:
Description:
Moves pixel to correct fire location
Steps to test this PR:
m.menu.page.zoom.changed.dailyandm.menu.page.zoom.changedshould fire