-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: head support #50
Conversation
Thanks for opening the PR! |
I think they are different because HEAD should not return back a response payload. So the implementation should only check for the existence of the resource and not try to retrive/return it. There would probably be performance implications as well fetching and returning a potentially a large payload that isn't used for the underlying dry run operation - hence prolonging the execution of the command. Yes - I will add tests. |
5f8d2f8
to
3f3dd34
Compare
@fox1t I've pushed tests but none of the tests pass locally for me (mabye configuration issues but not clear how to setup my env to be able to run locally) - but looks like the actions on CI passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@all-contributors please add @sppatel for code |
I've put up a pull request to add @sppatel! 🎉 |
# [1.7.0](v1.6.7...v1.7.0) (2022-10-14) ### Features * trigger release of head support [#50](#50) ([bc3bd8a](bc3bd8a))
# [1.7.0](ducktors/turborepo-remote-cache@v1.6.7...v1.7.0) (2022-10-14) ### Features * trigger release of head support [#50](ducktors/turborepo-remote-cache#50) ([bc3bd8a](ducktors/turborepo-remote-cache@bc3bd8a))
Turbo repo introduce support for
dry-run
to inspect caches and report on whether a cache entry in the local and/or remote cache exists for a given hash. In order to leverage, remote cache implementors must implement a HEAD route to check for the resource. This PR enables this.See the following for references..
vercel/turborepo#1437
vercel/turborepo#1988
and this article for use cases on leveraging this new info reported by dry-run.
https://medium.com/@sppatel/maximizing-job-parallelization-in-ci-workflows-with-jest-and-turborepo-da86b9be0ee6