Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing PassengerTitle enum values #886

Closed
Tom-Carpendale opened this issue Feb 9, 2024 · 1 comment
Closed

Missing PassengerTitle enum values #886

Tom-Carpendale opened this issue Feb 9, 2024 · 1 comment

Comments

@Tom-Carpendale
Copy link

The docs specify 5 possible values for PassengerTitle, but the typescript types represent 3 of them in upper and lowercase, and miss the other 2:

/**
* The passenger's title
*/
export type DuffelPassengerTitle = 'mr' | 'ms' | 'mrs' | 'MR' | 'MS' | 'MRS'

@andrejak
Copy link
Contributor

Hi @Tom-Carpendale , this should be fixed now after this PR: #887
If you see any issues with it please let us know. Feel free to also submit PRs in the future if it's a simple fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants