Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload log file #100

Merged
merged 2 commits into from
May 16, 2024
Merged

upload log file #100

merged 2 commits into from
May 16, 2024

Conversation

Dufgui
Copy link
Collaborator

@Dufgui Dufgui commented May 13, 2024

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have read and understand the Contributions section
  • I have performed a self-review of my code
  • I ran the unit tests and my PR does not break any tests
  • I documented the changes I've made on the CHANGES.md and followed actual conventions
  • I added a new section on how-to.md (optional)

@dufoli
Copy link
Owner

dufoli commented May 14, 2024

we need to add access to log from popup or from apx runner with a button without id.
and handle in log.js the missing id from parametter.

@Dufgui Dufgui force-pushed the upload_log branch 2 times, most recently from f690315 to 234098a Compare May 15, 2024 09:27
@Dufgui Dufgui marked this pull request as ready for review May 15, 2024 09:28
@Dufgui Dufgui self-assigned this May 15, 2024
@Dufgui Dufgui requested a review from dufoli May 15, 2024 09:30
@Dufgui
Copy link
Collaborator Author

Dufgui commented May 15, 2024

access from apex runner done, but no from popup, please define or code what you want.

@Dufgui Dufgui force-pushed the upload_log branch 3 times, most recently from cabc132 to c6e1164 Compare May 16, 2024 10:26
@Dufgui Dufgui merged commit 948ebbc into dufoli:master May 16, 2024
@Dufgui Dufgui deleted the upload_log branch May 16, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants