Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'arr' argument not used in get_bb_points #9

Open
sweetbeet opened this issue Jun 4, 2024 · 1 comment
Open

'arr' argument not used in get_bb_points #9

sweetbeet opened this issue Jun 4, 2024 · 1 comment

Comments

@sweetbeet
Copy link

Hi! I believe there might be a an unnecessary argument in get_bb_points as 'arr' is not being used within the function:
https://github.com/duhaime/lloyd/blob/a19557cc6282a8438be64e24af2be4375c3b1d32/lloyd/lloyd.py#L74C27-L74C30
@duhaime
Copy link
Owner

duhaime commented Jun 5, 2024

Hello! Thanks for your notes, these are great.

Yes, you're quite right, don't need that arg. If you send a merge request to remove it, I'll happily accept it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duhaime @sweetbeet