Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes tiled ".", ".." or containing URL/percent encoded characters are innaccesible after creation #209

Closed
danielmcmillan opened this issue Jun 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@danielmcmillan
Copy link

When a note is created with title "." and "..", they appear on the filesystem as "..md" and "...md" respectively. This is normal, but then trying to access those via the browser will take you to "/note/" or "/". They are still accessible via API.

When a note is created containing a URL encoded character, such as "a%3Db" (decodes to a=b), it is treated as a literal string as expected and appears on the filesystem as "a%3Db.md". However, when trying to access the note from the browser at the expected URL with the percent symbol being encoded "/note/a%253Db" the note cannot be found.
The API request being sent is for "a=b", so it may be that the name from the URL is incorrectly being decoded a second time. The note can be accessed by double-encoding the note name in the url "/note/a%25253Db".

@dullage
Copy link
Owner

dullage commented Jul 4, 2024

Thanks. Fixed in this commit and will be in the next release.

@dullage dullage closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants