Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abandon additional transport method parameter #2

Open
napsy opened this issue Apr 28, 2015 · 3 comments
Open

Abandon additional transport method parameter #2

napsy opened this issue Apr 28, 2015 · 3 comments

Comments

@napsy
Copy link

napsy commented Apr 28, 2015

Most of the time, users won't care what is the underlaying communication protocol.
So, I propose:

func NewPlugin(path string, params ...string) *Plugin

To change the default communication protocol, expose:

func SetProto(proto string)

The API becomes clearer. E.g.:

p := pingo.NewPlugin("plugins/hello-world/hello-world")
@dullgiulio
Copy link
Owner

Agreed. This would also help implementing automatic switching of protocol.

@kdar
Copy link

kdar commented May 1, 2015

Would be nice to use RPC over stdin/stdout too.

@dullgiulio
Copy link
Owner

@kdar: I'll make a new issue for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants